From 2df5e9e5a4d09ab4fc94aabb65656d9395f32e8d Mon Sep 17 00:00:00 2001 From: Nicolas Dumazet <nicolas.dumazet@nexedi.com> Date: Fri, 19 Feb 2010 02:21:44 +0000 Subject: [PATCH] dont use 'id' as a local variable: it's already a function parameter The typical example of why using short variable names is evil =) git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@32813 20353a03-c40f-0410-a6d1-a30d3c3de9de --- product/ERP5Type/XMLMatrix.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/product/ERP5Type/XMLMatrix.py b/product/ERP5Type/XMLMatrix.py index ee2ed6b233..2caf240e67 100644 --- a/product/ERP5Type/XMLMatrix.py +++ b/product/ERP5Type/XMLMatrix.py @@ -471,19 +471,19 @@ class XMLMatrix(Folder): return self.newCellContent(cell_id,**kwd) security.declareProtected( Permissions.ModifyPortalContent, 'newCellContent' ) - def newCellContent(self, id, portal_type=None, **kw): + def newCellContent(self, cell_id, portal_type=None, **kw): """ Creates a new content as a cell. This method is meant to be overriden by subclasses. """ if portal_type is None: for x in self.allowedContentTypes(): - id = x.getId() + portal_type_id = x.getId() if id.endswith(' Cell'): - portal_type = id + portal_type = portal_type_id break - return self.newContent(id=id, portal_type=portal_type, **kw) + return self.newContent(id=cell_id, portal_type=portal_type, **kw) security.declareProtected( Permissions.AccessContentsInformation, 'getCellKeyList' ) -- 2.30.9