From ea4debfe91cb98c8af8c9fcba449325bbe6da62d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9rome=20Perrin?= <jerome@nexedi.com> Date: Thu, 13 Jan 2022 19:20:36 +0900 Subject: [PATCH] dms: rename print actions not to conflict with erp5_odt_style odt_style comes with "Print" global actions which allows getting the default form as ODT and convert it to selected format and DMS comes with "Print" actions which return a PDF of the document content. As a result, when user try to use Print, they have the same action twice with no way to know which one is which. This is detected by CodingStyleTestCase.test_DuplicateActions, but only for configurations where both erp5_odt_style and erp5_dms are installed, which is not the case in coding style test suite which only install the miminmal dependent business templates. --- bt5/erp5_dms/ActionTemplateItem/portal_types/Drawing/print.xml | 2 +- .../ActionTemplateItem/portal_types/Presentation/print.xml | 2 +- .../ActionTemplateItem/portal_types/Spreadsheet/print.xml | 2 +- bt5/erp5_dms/ActionTemplateItem/portal_types/Text/print.xml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/bt5/erp5_dms/ActionTemplateItem/portal_types/Drawing/print.xml b/bt5/erp5_dms/ActionTemplateItem/portal_types/Drawing/print.xml index a2e09c1c06..e04dcf263f 100644 --- a/bt5/erp5_dms/ActionTemplateItem/portal_types/Drawing/print.xml +++ b/bt5/erp5_dms/ActionTemplateItem/portal_types/Drawing/print.xml @@ -56,7 +56,7 @@ </item> <item> <key> <string>title</string> </key> - <value> <string>Print</string> </value> + <value> <string>Print as PDF</string> </value> </item> <item> <key> <string>visible</string> </key> diff --git a/bt5/erp5_dms/ActionTemplateItem/portal_types/Presentation/print.xml b/bt5/erp5_dms/ActionTemplateItem/portal_types/Presentation/print.xml index a2e09c1c06..e04dcf263f 100644 --- a/bt5/erp5_dms/ActionTemplateItem/portal_types/Presentation/print.xml +++ b/bt5/erp5_dms/ActionTemplateItem/portal_types/Presentation/print.xml @@ -56,7 +56,7 @@ </item> <item> <key> <string>title</string> </key> - <value> <string>Print</string> </value> + <value> <string>Print as PDF</string> </value> </item> <item> <key> <string>visible</string> </key> diff --git a/bt5/erp5_dms/ActionTemplateItem/portal_types/Spreadsheet/print.xml b/bt5/erp5_dms/ActionTemplateItem/portal_types/Spreadsheet/print.xml index a2e09c1c06..e04dcf263f 100644 --- a/bt5/erp5_dms/ActionTemplateItem/portal_types/Spreadsheet/print.xml +++ b/bt5/erp5_dms/ActionTemplateItem/portal_types/Spreadsheet/print.xml @@ -56,7 +56,7 @@ </item> <item> <key> <string>title</string> </key> - <value> <string>Print</string> </value> + <value> <string>Print as PDF</string> </value> </item> <item> <key> <string>visible</string> </key> diff --git a/bt5/erp5_dms/ActionTemplateItem/portal_types/Text/print.xml b/bt5/erp5_dms/ActionTemplateItem/portal_types/Text/print.xml index e4c00f9ef5..41c479db39 100644 --- a/bt5/erp5_dms/ActionTemplateItem/portal_types/Text/print.xml +++ b/bt5/erp5_dms/ActionTemplateItem/portal_types/Text/print.xml @@ -56,7 +56,7 @@ </item> <item> <key> <string>title</string> </key> - <value> <string>Print</string> </value> + <value> <string>Print as PDF</string> </value> </item> <item> <key> <string>visible</string> </key> -- 2.30.9