1. 28 Mar, 2024 23 commits
  2. 26 Mar, 2024 4 commits
  3. 25 Mar, 2024 1 commit
    • Titouan Soulard's avatar
      ERP5Type: fix dummy memcached placeholder · 0345d19e
      Titouan Soulard authored
      When trying to use `MemcachedTool` without the `python-memcached` package,
      a dummy implementation is supposed to allow installation while giving a
      warning when called.
      
      This dummy implementation was broken because it was calling a wrong class,
      named `_MemcachedTool`, which did not exist. Instead, `_MemcacheTool` did
      exist and was used for the real implementation.
      
      This commit renames `_MemcacheTool` to `_MemcachedTool` to allow dummy
      implementation to work.
      0345d19e
  4. 21 Mar, 2024 3 commits
    • Jérome Perrin's avatar
      officejs: fix a wrong ID in a PathTemplateItem object · e9c62981
      Jérome Perrin authored
      Fixes an logged error while indexing:
      
          2024-03-07 23:44:21.997 WARNING CMFActivity Message dropped (no object found at path ('', 'erp5_portal_ec7d28d9ada99a2cad998125d59fc158', 'image_module', 'gadget_officejs_appstore_app_text_editor_icon_text_editor_png'))
          Traceback (most recent call last):
            File "/srv/slapgrid/slappart22/t/eje/soft/de456d85f70e1b1a086396326977c83c/parts/erp5/product/CMFActivity/ActivityTool.py", line 262, in getObject
              obj = self._getObject(activity_tool)
            File "/srv/slapgrid/slappart22/t/eje/soft/de456d85f70e1b1a086396326977c83c/parts/erp5/product/CMFActivity/ActivityTool.py", line 256, in _getObject
              obj = obj[id]
            File "/srv/slapgrid/slappart22/t/eje/soft/de456d85f70e1b1a086396326977c83c/eggs/Zope-4.8.9+slapospatched002-py2.7.egg/OFS/ObjectManager.py", line 843, in __getitem__
              raise KeyError(key)
          KeyError: 'gadget_officejs_appstore_app_text_editor_icon_text_editor_png'
      e9c62981
    • Rafael Monnerat's avatar
      erp5_xhtml_style: Dont jump to workflow manage main · 9805e260
      Rafael Monnerat authored
         Workflows now are viable from ERP5 UI, so redirect to /view instead
      9805e260
    • Jérome Perrin's avatar
      Fix code depending on python2 __hash__ · 0ed7ff48
      Jérome Perrin authored
      With python2, iterating on a dictionary or a set always produces the same result,
      although this is not a documented behavior. On python3 this is not the case,
      because the hashing algorithm is random by default, which can also be set using [`PYTHONHASHSEED`](https://docs.python.org/3/using/cmdline.html#envvar-PYTHONHASHSEED). On SlapOS, this is done with nexedi/slapos!1535 
      
      This fixes the parts where ERP5 code depends on python2 order, mostly tests, but also places
      where we iterate on a dictionary or set. Most of the time, the fix has been to sort so that
      the order is deterministic regardless of the hash algorithm randomization, but sometimes we
      had to extend a bit the configuration where the order was really important. We did this after
      discovering the problematic areas by running tests multiple times with different hash randomization
      seeds. It's not impossible that changing from "default python2 order" to "sorted" reveals some
      more problems in custom configurations, but this would mean that the configuration must be 
      adjusted to use explicit order instead of being lucky with the default python2 order.
      
      The main pattern was the use of `edit` method which edits properties in an order that is a bit
      constrained with the `edit_order` mechanism, because some properties depend on other properties,
      so it's important to set them in order. This extends a bit the `edit_order` mechanism to specify
      more properties that were edited in the right order with `PYTHONHASHSEED=0` by chance.
      
      This also extends delivery builders to edit properties in order defined in the equivalence tester,
      most equivalence tester were already properly configured, except the `start_date` and `stop_date`
      from delivery level movement groups. That probably only matters for some specific test assertions,
      but in practice this was visible in a lot of failing tests.
      
      Some visible changes are that:
       - workflows are now sorted alphabetically on history tab
       - properties are now sorted alphabetically on the diff view of history tab
       - business templates are installed in the order of dependencies and in alphabetic order when they
        are not constrained.
      
      See merge request nexedi/erp5!1882
      0ed7ff48
  5. 19 Mar, 2024 9 commits
    • Rafael Monnerat's avatar
      erp5_json_editor: Sanitize and update description on schema · a56f5a9d
      Rafael Monnerat authored
        Remove forbidden properties when retrieve the properties from the schema.
      
            - template and options isn't  part of json schema spec, so it isn't possible to use this feature globally.
            - template also could be used to call callbacks, so despite we block unsafe-eval, it still better remove it.
            - both were removed because it can lead to parameter injection, where by saving the form w/o editing anything, it changes the parameters, it adds non-visible values, which can up to some extend be a security risk.
      
         Update the description to display the "default" value as a hint, if it was provided into the schema.
      a56f5a9d
    • Jérome Perrin's avatar
      ZSQLCatalog: support dict.keys()/items() as search values · 7b94ed40
      Jérome Perrin authored
      constructs like `portal_catalog(title=d.keys())` were allowed on
      python2, we can allow them on python3 as well.
      7b94ed40
    • Jérome Perrin's avatar
    • Georgios Dagkakis's avatar
      b51e56e0
    • Georgios Dagkakis's avatar
      8fcb9617
    • Georgios Dagkakis's avatar
      4814de64
    • Georgios Dagkakis's avatar
    • Georgios Dagkakis's avatar
    • Klaus Wölfel's avatar
      Fix a broken case of Worklist calculation when using security_uid columns · 840066ac
      Klaus Wölfel authored
      With some combinations of worklists using two additional security_uid
      columns coming from local role groups, some documents might be excluded
      from worklists, without the fix, when running with a random
      PYTHONHASHSEED, the test can fail with:
      
          FAIL: test_worklist_exclusionlist_collision (erp5.component.test.erp5_version.testERP5CatalogSecurityUidOptimization.TestSecurityUidOptimizationWorklist)
          ----------------------------------------------------------------------
          Traceback (most recent call last):
            File "<portal_components/test.erp5.testERP5CatalogSecurityUidOptimization>", line 370, in test_worklist_exclusionlist_collision
              'security_uid_or_alternate_security_uid_draft': 1,
            File "<portal_components/test.erp5.testERP5CatalogSecurityUidOptimization>", line 213, in assertWorklistCount
              expected_count_by_worklist_id,
          AssertionError: {'security_uid_or_alternate_security_uid_draft': 1} != {'collision_worklist': 1, 'security_uid_or_alternate_security_uid_draft': 1}
          - {'security_uid_or_alternate_security_uid_draft': 1}
          + {'collision_worklist': 1, 'security_uid_or_alternate_security_uid_draft': 1}
          ?  +++++++++++++++++++++++++
      
      What happens in sumCatalogResultByWorklist is something like this:
      
          (Pdb) pp criterion_dict
          {'alternate_security_uid': <ExclusionList [11, 14]>,
           'other_security_uid': frozenset([13L]),
           'portal_type': frozenset(['Person']),
           'validation_state': frozenset(['draft'])}
      
          (Pdb) pp catalog_result.dictionaries()
          [{'alternate_security_uid': 12,
            'count': Decimal('1'),
            'other_security_uid': 13,
            'portal_type': 'Person',
            'validation_state': 'draft'}]
      
      Depending on the worklists grouped together in grouped_worklist_dict and
      the order this dict is iterated, we may reach a situation where
      criterion_id_list contains 'alternate_security_uid', because for another
      worklist it was not an ExclusionList but a list to be applied, in this
      case, this if condition is false:
      
              for criterion_id in criterion_id_list:
                criterion_value_set = criterion_dict[criterion_id]
                if result_line[criterion_id] not in criterion_value_set:
                  is_candidate = False
      
      and the row is not counted in collision_worklist worklist.
      Co-authored-by: Jérome Perrin's avatarJérome Perrin <jerome@nexedi.com>
      840066ac