slapgrid: Update retrieve certificate to specific record

slapos/grid/SlapObject.py

@@ -501,25 +501,15 @@ class Partition(object):
                                       available=bytes2human(available),
                                       required=bytes2human(required)))
 
-  def _updateCertificate(self):
+  def _updateCertificate(self, partition_certificates):
     if not self.key_file or not self.cert_file:
       # Certificate files are unset, skip.
       return
 
-    if self.api_backward_compatibility:
-      try:
-        partition_certificate = self.computer_partition["slap_partition"].getCertificate()
-        self.computer_partition["X509"] = {}
-        self.computer_partition["X509"]["certificate"] = partition_certificate["certificate"]
-        self.computer_partition["X509"]["key"] = partition_certificate["key"]
-      except NotFoundError:
-        raise NotFoundError('Partition %s is not known by SlapOS Master.' %
-            self.partition_id)
-
     uid, gid = self.getUserGroupId()
 
     for name, path in [('certificate', self.cert_file), ('key', self.key_file)]:
-      new_content = self.computer_partition["X509"][name]
+      new_content = partition_certificates[name]
       old_content = None
       if os.path.exists(path):
         with open(path) as f:

slapos/grid/slapgrid.py

@@ -1175,6 +1175,19 @@ stderr_logfile_backups=1
       self._checkAddFirewallRules(computer_partition.get("compute_partition_id"),
                                   cmd_list, add=add_rules)
 
+  def retrieveCertificates(self, computer_partition):
+    if not self.api_backward_compatibility:
+      partition_certificates = self.slap.jio_api_connector.get({
+        "portal_type": "Software Instance Certificate Record",
+        "reference": computer_partition.get("reference"),
+      })
+    else:
+      try:
+        partition_certificates = computer_partition["slap_partition"].getCertificate()
+      except NotFoundError:
+        raise NotFoundError('Partition %s is not known by SlapOS Master.' % computer_partition.get("reference"))
+    return partition_certificates
+
   def _checkPromiseAnomaly(self, local_partition, computer_partition):
     partition_access_status = computer_partition.get("access_status_message", "")
     status_error = False
@@ -1187,11 +1200,11 @@ stderr_logfile_backups=1
     except PromiseError as e:
       self.logger.error(e)
       if partition_access_status is None or not status_error:
-        local_partition._updateCertificate()
+        local_partition._updateCertificate(self.retrieveCertificates(computer_partition))
         self.sendPartitionError(computer_partition, e, logger=self.logger)
     else:
       if partition_access_status is None or status_error:
-        local_partition._updateCertificate()
+        local_partition._updateCertificate(self.retrieveCertificates(computer_partition))
         if not self.api_backward_compatibility:
           self.slap.jio_api_connector.put({
             "portal_type": "Software Instance",
@@ -1408,7 +1421,7 @@ stderr_logfile_backups=1
       self.logger.info('  jIO API used: %s' % (not self.api_backward_compatibility))
 
       # Update certifcate at late as possible
-      local_partition._updateCertificate()
+      local_partition._updateCertificate(self.retrieveCertificates(computer_partition))
 
       # XXX this line breaks 37 tests
       # self.logger.info('  Instance type: %s' % computer_partition.get("software_type"))
@@ -2085,7 +2098,7 @@ stderr_logfile_backups=1
             api_backward_compatibility=self.api_backward_compatibility,
           )
           local_partition.stop()
-          local_partition._updateCertificate()
+          local_partition._updateCertificate(self.retrieveCertificates(computer_partition))
           try:
             if not self.api_backward_compatibility:
               self.slap.jio_api_connector.put({