slapos_accounting: test: fixup testSlapOSAccountingConstraint

master/bt5/slapos_accounting/TestTemplateItem/portal_components/test.erp5.testSlapOSAccountingConstraint.py

@@ -11,7 +11,6 @@ from unittest import skip
 
 import transaction
 
-AGGREGATE_SALE_TRADE_CONDITION_RELATIVE_URL = 'sale_trade_condition_module/slapos_aggregated_trade_condition_v3'
 
 class TestHostingSubscription(TestSlapOSConstraintMixin):
 
@@ -152,16 +151,14 @@ class TestSaleInvoiceTransaction(TestSlapOSConstraintMixin):
   def test_specialise_value(self):
     invoice = self.portal.accounting_module.newContent(
         portal_type='Sale Invoice Transaction')
-    message = "Only SlapOS trade condition is allowed"
+    message = "Arity Error for Relation ['specialise'] and Type " + \
+      "('Sale Trade Condition',), arity is equal to 0 but should be at least 1"
     self.assertTrue(message in self.getMessageList(invoice))
 
     sale_condition = self.portal.sale_trade_condition_module.newContent(
         portal_type='Sale Trade Condition')
     invoice.setSpecialise(sale_condition.getRelativeUrl())
 
-    self.assertTrue(message in self.getMessageList(invoice))
-
-    invoice.setSpecialise(AGGREGATE_SALE_TRADE_CONDITION_RELATIVE_URL)
     self.assertFalse(message in self.getMessageList(invoice))
 
   @withAbort
@@ -183,10 +180,35 @@ class TestSaleInvoiceTransaction(TestSlapOSConstraintMixin):
   @withAbort
   def test_trade_model_match_lines(self):
     message = "Defined Trade Model does not match Lines definition"
+    currency = self.portal.currency_module.EUR
+    sale_trade_condition = self.portal.sale_trade_condition_module.newContent(
+      portal_type="Sale Trade Condition",
+      reference="Tax/payment for: %s" % currency.getRelativeUrl(),
+      trade_condition_type="default",
+      # XXX hardcoded
+      specialise="business_process_module/slapos_ultimate_business_process",
+      price_currency_value=currency,
+      payment_condition_payment_mode='test-%s' % self.generateNewId()
+    )
+    sale_trade_condition.newContent(
+      portal_type="Trade Model Line",
+      reference="VAT",
+      resource="service_module/slapos_tax",
+      base_application="base_amount/invoicing/taxable",
+      trade_phase="slapos/tax",
+      price=0.2,
+      quantity=1.0,
+      membership_criterion_base_category=('price_currency', 'base_contribution'),
+      membership_criterion_category=(
+        'price_currency/%s' % currency.getRelativeUrl(),
+        'base_contribution/base_amount/invoicing/taxable'
+      )
+    )
+    sale_trade_condition.validate()
     invoice = self.portal.accounting_module.newContent(
         portal_type='Sale Invoice Transaction',
-        price_currency='currency_module/EUR',
-        specialise=AGGREGATE_SALE_TRADE_CONDITION_RELATIVE_URL)
+        price_currency_value=currency,
+        specialise_value=sale_trade_condition)
     invoice.newContent(portal_type='Invoice Line', quantity=1., price=1.,
         base_contribution='base_amount/invoicing/taxable')
 
@@ -202,20 +224,47 @@ class TestSaleInvoiceTransaction(TestSlapOSConstraintMixin):
   @withAbort
   def test_use_trade_sale_total_price_matches_delivery_constraint(self):
     message = "Total price does not match related Sale Packing List"
+    currency = self.portal.currency_module.EUR
+    sale_trade_condition = self.portal.sale_trade_condition_module.newContent(
+      portal_type="Sale Trade Condition",
+      reference="Tax/payment for: %s" % currency.getRelativeUrl(),
+      trade_condition_type="default",
+      # XXX hardcoded
+      specialise="business_process_module/slapos_ultimate_business_process",
+      price_currency_value=currency,
+      payment_condition_payment_mode='test-%s' % self.generateNewId()
+    )
+    sale_trade_condition.newContent(
+      portal_type="Trade Model Line",
+      reference="VAT",
+      resource="service_module/slapos_tax",
+      base_application="base_amount/invoicing/taxable",
+      trade_phase="slapos/tax",
+      price=0.2,
+      quantity=1.0,
+      membership_criterion_base_category=('price_currency', 'base_contribution'),
+      membership_criterion_category=(
+        'price_currency/%s' % currency.getRelativeUrl(),
+        'base_contribution/base_amount/invoicing/taxable'
+      )
+    )
+    sale_trade_condition.validate()
+
     delivery = self.portal.sale_packing_list_module.newContent(
       portal_type='Sale Packing List')
     delivery.newContent(portal_type='Sale Packing List Line',
       use='trade/sale', quantity=1., price=1.)
     invoice = self.portal.accounting_module.newContent(
         portal_type='Sale Invoice Transaction',
-        causality=delivery.getRelativeUrl())
+        ledger="automated",
+        specialise_value=sale_trade_condition)
     invoice_line = invoice.newContent(portal_type='Invoice Line', quantity=2.,
         price=1., use='trade/sale')
 
     self.assertFalse(message in self.getMessageList(invoice))
     self.portal.portal_workflow._jumpToStateFor(invoice, 'confirmed')
     self.assertFalse(message in self.getMessageList(invoice))
-    invoice.setSpecialise(AGGREGATE_SALE_TRADE_CONDITION_RELATIVE_URL)
+    invoice.setCausalityValue(delivery)
     self.assertTrue(message in self.getMessageList(invoice))
     invoice_line.setQuantity(1.)
     self.assertFalse(message in self.getMessageList(invoice))
@@ -304,9 +353,6 @@ class TestSalePackingList(TestSlapOSConstraintMixin):
   def test_source(self):
     self._test_category_arrow('source')
 
-  def test_source_section(self):
-    self._test_category_arrow('source_section')
-
   @withAbort
   def test_specialise(self):
     category = 'specialise'
@@ -345,28 +391,20 @@ class TestSalePackingList(TestSlapOSConstraintMixin):
 class TestSalePackingListLine(TestSlapOSConstraintMixin):
   @withAbort
   def test_property_existence(self):
-    message = 'Property existence error for property %s, this document has '\
-        'no such property or the property has never been set'
-    message_price = message % 'price'
-    message_quantity = message % 'quantity'
+    message_quantity = 'No quantity defined'
     delivery_line = self.portal.sale_packing_list_module.newContent(
         portal_type='Sale Packing List').newContent(
         portal_type='Sale Packing List Line')
-    self.assertTrue(message_price in self.getMessageList(delivery_line))
     self.assertTrue(message_quantity in self.getMessageList(delivery_line))
     delivery_line.setQuantity(1.0)
-    self.assertTrue(message_price in self.getMessageList(delivery_line))
-    self.assertFalse(message_quantity in self.getMessageList(delivery_line))
-    delivery_line.setPrice(1.0)
-    self.assertFalse(message_price in self.getMessageList(delivery_line))
     self.assertFalse(message_quantity in self.getMessageList(delivery_line))
 
   @withAbort
   def test_resource_arity(self):
     category = 'resource'
-    message = "Arity Error for Relation ['%s'] and Type ('Data Operation', 'Service'), arity is"\
+    message = "Arity Error for Relation ['%s'] and Type ('Data Operation', 'Service', 'Software Product'), arity is"\
         " equal to 0 but should be between 1 and 1" % category
-    message_2 = "Arity Error for Relation ['%s'] and Type ('Data Operation', 'Service'), arity is"\
+    message_2 = "Arity Error for Relation ['%s'] and Type ('Data Operation', 'Service', 'Software Product'), arity is"\
         " equal to 2 but should be between 1 and 1" % category
     delivery_line = self.portal.sale_packing_list_module.newContent(
         portal_type='Sale Packing List').newContent(