erp5testnode: store shellinabox password in a dedicated file

slapos/recipe/shellinabox.py

@@ -33,19 +33,24 @@ import shlex
 from slapos.recipe.librecipe import GenericBaseRecipe
 
 def login_shell(args):
-  password = args['password']
-  
-  if (password != ''):
-    entered_password = getpass()
-  else:
-    entered_password = ''
+  shellinabox_password_file = args['shellinabox-password-file']
+  if shellinabox_password_file:
+    with open(shellinabox_password_file, 'r') as password_file:
+      password = password_file.read()
 
-  if entered_password != password:
-    return 1
+    if (password != ''):
+      entered_password = getpass()
+    else:
+      entered_password = ''
+
+    if entered_password != password:
+      return 1
+    else:
+      commandline = shlex.split(args['shell'])
+      path = commandline[0]
+      os.execv(path, commandline)
   else:
-    commandline = shlex.split(args['shell'])
-    path = commandline[0]
-    os.execv(path, commandline)
+    return 1
 
 def shellinabox(args):
   certificate_dir = args['certificate_dir']
@@ -95,12 +100,15 @@ class Recipe(GenericBaseRecipe):
       self.options['login-shell'],
       '%s.login_shell' % __name__,
       {
-        'password': self.options['password'],
+        'shellinabox-password-file': self.options['shellinabox-password-file'],
         'shell': self.options['shell']
       }
     )
     path_list.append(login_shell)
 
+    with open(self.options['shellinabox-password-file'], 'w') as password_file:
+      password_file.write(self.options['password'])
+
     wrapper = self.createPythonScript(
       self.options['wrapper'],
       '%s.shellinabox' % __name__,

software/erp5testnode/instance-default.cfg

@@ -94,6 +94,7 @@ port = 8080
 shell = $${shell:wrapper}
 wrapper = $${rootdirectory:bin}/shellinaboxd
 shellinabox-binary = ${shellinabox:location}/bin/shellinaboxd
+shellinabox-password-file = $${rootdirectory:etc}/shellinabox-password
 password = $${pwgen:passwd}
 directory = $${buildout:directory}/
 login-shell = $${rootdirectory:bin}/login

software/erp5testnode/software.cfg

@@ -56,7 +56,7 @@ recipe = slapos.recipe.template
 url = ${:_profile_base_location_}/instance-default.cfg
 output = ${buildout:directory}/template-default.cfg
 mode = 0644
-md5sum =  8e171816b6caef52ac75c2f8f6a69fc3
+md5sum = 4cff4f92ab230ccf02283bf924e32089
 
 [versions]
 PyXML = 0.8.5