.

go/neo/client.go

@@ -18,9 +18,7 @@
 // See https://www.nexedi.com/licensing for rationale and options.
 
 package neo
-// client node
-
-// XXX old: Package client provides ZODB storage interface for accessing NEO cluster.
+// client node with ZODB storage interface for accessing NEO cluster.
 
 import (
 	"context"
@@ -103,7 +101,7 @@ func (cli *Client) run(ctx context.Context) error {
 
 func (c *Client) Close() error {
 	c.talkMasterCancel()
-	// XXX wait talkMaster finishes
+	// XXX wait talkMaster finishes -> XXX return err from that?
 	// XXX what else?
 	return nil
 }

go/neo/cluster_test.go

@@ -26,6 +26,7 @@ import (
 	"bytes"
 	"context"
 	"crypto/sha1"
+	"fmt"
 	"io"
 	"net"
 	"reflect"
@@ -50,7 +51,6 @@ import (
 	"lab.nexedi.com/kirr/go123/xnet"
 	"lab.nexedi.com/kirr/go123/xnet/pipenet"
 
-	"fmt"
 	"time"
 )
 

go/neo/cmd/neo/master.go

@@ -66,13 +66,6 @@ func masterMain(argv []string) {
 	net := xnet.NetPlain("tcp")	// TODO + TLS; not only "tcp" ?
 
 	ctx := context.Background()
-	/*
-	ctx, cancel := context.WithCancel(context.Background())
-	go func() {
-		time.Sleep(3 * time.Second)
-		cancel()
-	}()
-	*/
 
 	err := listenAndServe(ctx, net, *bind, func(ctx context.Context, l stdnet.Listener) error {
 		master := neo.NewMaster(*cluster, net)

go/neo/cmd/neo/storage.go

@@ -99,13 +99,6 @@ func storageMain(argv []string) {
 	runtime.GOMAXPROCS(maxprocs*8)		// XXX *8 is enough?
 
 	ctx := context.Background()
-	/*
-	ctx, cancel := context.WithCancel(context.Background())
-	go func() {
-		time.Sleep(3 * time.Second)
-		cancel()
-	}()
-	*/
 
 	back, err := storage.OpenBackend(ctx, argv[0])
 	if err != nil {

go/neo/master.go

@@ -43,7 +43,7 @@ import (
 	"lab.nexedi.com/kirr/neo/go/xcommon/xio"
 )
 
-// Master is a node overseeing and managing how whole NEO cluster works
+// Master is a node overseeing and managing how whole NEO cluster works.
 type Master struct {
 	node *NodeApp
 

go/neo/storage.go

@@ -324,7 +324,7 @@ func (stor *Storage) m1initialize1(ctx context.Context, req neonet.Request) erro
 //
 // Service is regular phase serving requests from clients to load/save objects,
 // handling transaction commit (with master) and syncing data with other
-// storage nodes (XXX correct?).
+// storage nodes.
 //
 // it always returns with an error describing why serve had to be stopped -
 // either due to master commanding us to stop, or context cancel or some other
@@ -342,7 +342,7 @@ func (stor *Storage) m1serve(ctx context.Context, reqStart *neonet.Request) (err
 	defer opCancel()
 
 	// reply M we are ready
-	// XXX according to current neo/py this is separate send - not reply - and so we do here
+	// XXX NEO/py sends NotifyReady on another conn; we patched py; see 4eaaf186 for context
 	err = reqStart.Reply(&proto.NotifyReady{})
 	reqStart.Close()
 	if err != nil {

go/neo/t/tcpu.py

@@ -52,8 +52,8 @@ def prettyarg(arg):
 
 # ---- 8< ---- from wendelin.core/t/py.bench
 
-# benchmarking timer/request passed to benchmarks as fixture
-# similar to https://golang.org/pkg/testing/#B
+# B is benchmarking timer/request passed to benchmarks as fixture
+# similar to https://golang.org/pkg/testing/#B.
 class B:
 
     def __init__(self):

go/xcommon/xtracing/tracetest/tracetest.go

@@ -18,7 +18,7 @@
 // See https://www.nexedi.com/licensing for rationale and options.
 
 // Package tracetest provides infrastructure for testing concurrent systems
-// based on synchronous events tracing.
+// based on synchronous event tracing.
 //
 // A serial system can be verified by checking that its execution produces
 // expected serial stream of events. But concurrent systems cannot be verified