Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Tatuya Kamada
gitlab-ce
Commits
0e89ff0f
Commit
0e89ff0f
authored
Apr 18, 2015
by
Robert Speicher
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Simplify `Note#upvote?` and `Note#downvote?`
parent
5d08a5a5
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
11 additions
and
17 deletions
+11
-17
app/models/note.rb
app/models/note.rb
+11
-17
No files found.
app/models/note.rb
View file @
0e89ff0f
...
@@ -449,16 +449,6 @@ class Note < ActiveRecord::Base
...
@@ -449,16 +449,6 @@ class Note < ActiveRecord::Base
@discussion_id
||=
Note
.
build_discussion_id
(
noteable_type
,
noteable_id
||
commit_id
,
line_code
)
@discussion_id
||=
Note
.
build_discussion_id
(
noteable_type
,
noteable_id
||
commit_id
,
line_code
)
end
end
# Returns true if this is a downvote note,
# otherwise false is returned
def
downvote?
votable?
&&
(
note
.
start_with?
(
'-1'
)
||
note
.
start_with?
(
':-1:'
)
||
note
.
start_with?
(
':thumbsdown:'
)
||
note
.
start_with?
(
':thumbs_down_sign:'
)
)
end
def
for_commit?
def
for_commit?
noteable_type
==
"Commit"
noteable_type
==
"Commit"
end
end
...
@@ -500,14 +490,18 @@ class Note < ActiveRecord::Base
...
@@ -500,14 +490,18 @@ class Note < ActiveRecord::Base
nil
nil
end
end
# Returns true if this is an upvote note,
DOWNVOTES
=
%w(-1 :-1: :thumbsdown: :thumbs_down_sign:)
# otherwise false is returned
# Check if the note is a downvote
def
downvote?
votable?
&&
note
.
start_with?
(
*
DOWNVOTES
)
end
UPVOTES
=
%w(+1 :+1: :thumbsup: :thumbs_up_sign:)
# Check if the note is an upvote
def
upvote?
def
upvote?
votable?
&&
(
note
.
start_with?
(
'+1'
)
||
votable?
&&
note
.
start_with?
(
*
UPVOTES
)
note
.
start_with?
(
':+1:'
)
||
note
.
start_with?
(
':thumbsup:'
)
||
note
.
start_with?
(
':thumbs_up_sign:'
)
)
end
end
def
superceded?
(
notes
)
def
superceded?
(
notes
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment