Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Tatuya Kamada
gitlab-ce
Commits
2332bf34
Commit
2332bf34
authored
Apr 02, 2017
by
mhasbini
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove unnecessary ORDER BY clause when updating todos
parent
9fc17f6f
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
5 additions
and
1 deletion
+5
-1
app/services/todo_service.rb
app/services/todo_service.rb
+1
-1
changelogs/unreleased/todo-update-order.yml
changelogs/unreleased/todo-update-order.yml
+4
-0
No files found.
app/services/todo_service.rb
View file @
2332bf34
...
@@ -204,7 +204,7 @@ class TodoService
...
@@ -204,7 +204,7 @@ class TodoService
# Only update those that are not really on that state
# Only update those that are not really on that state
todos
=
todos
.
where
.
not
(
state:
state
)
todos
=
todos
.
where
.
not
(
state:
state
)
todos_ids
=
todos
.
pluck
(
:id
)
todos_ids
=
todos
.
pluck
(
:id
)
todos
.
update_all
(
state:
state
)
todos
.
u
nscope
(
:order
).
u
pdate_all
(
state:
state
)
current_user
.
update_todos_count_cache
current_user
.
update_todos_count_cache
todos_ids
todos_ids
end
end
...
...
changelogs/unreleased/todo-update-order.yml
0 → 100644
View file @
2332bf34
---
title
:
Remove unnecessary ORDER BY clause when updating todos
merge_request
:
author
:
mhasbini
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment