Commit 52d5d7da authored by Kamil Trzcinski's avatar Kamil Trzcinski

Create PipelinesSettingsController for showing settings page

parent 7e8ef1b8
class Projects::PipelinesController < Projects::ApplicationController class Projects::PipelinesController < Projects::ApplicationController
before_action :pipeline, except: [:index, :new, :create, :settings, :update_settings] before_action :pipeline, except: [:index, :new, :create]
before_action :commit, only: [:show] before_action :commit, only: [:show]
before_action :authorize_read_pipeline! before_action :authorize_read_pipeline!
before_action :authorize_create_pipeline!, only: [:new, :create] before_action :authorize_create_pipeline!, only: [:new, :create]
before_action :authorize_update_pipeline!, only: [:retry, :cancel] before_action :authorize_update_pipeline!, only: [:retry, :cancel]
before_action :authorize_admin_pipeline!, only: [:settings, :update_settings]
def index def index
@scope = params[:scope] @scope = params[:scope]
...@@ -44,36 +43,12 @@ class Projects::PipelinesController < Projects::ApplicationController ...@@ -44,36 +43,12 @@ class Projects::PipelinesController < Projects::ApplicationController
redirect_back_or_default default: namespace_project_pipelines_path(project.namespace, project) redirect_back_or_default default: namespace_project_pipelines_path(project.namespace, project)
end end
def settings
@ref = params[:ref] || @project.default_branch || 'master'
@build_badge = Gitlab::Badge::Build.new(@project, @ref)
end
def update_settings
if @project.update_attributes(pipelines_settings_params)
flash[:notice] = "CI/CD Pipelines settings for '#{@project.name}' was successfully updated."
redirect_to(
settings_namespace_project_pipelines_path(@project.namespace, @project),
notice: "CI/CD Pipelines settings for '#{@project.name}' was successfully updated."
)
else
render 'settings'
end
end
private private
def create_params def create_params
params.require(:pipeline).permit(:ref) params.require(:pipeline).permit(:ref)
end end
def pipelines_settings_params
params.require(:project).permit(
:runners_token, :builds_enabled, :build_allow_git_fetch, :build_timeout_in_minutes, :build_coverage_regex,
:public_builds
)
end
def pipeline def pipeline
@pipeline ||= project.pipelines.find_by!(id: params[:id]) @pipeline ||= project.pipelines.find_by!(id: params[:id])
end end
......
class Projects::PipelinesSettingsController < Projects::ApplicationController
before_action :authorize_admin_pipeline!
def show
@ref = params[:ref] || @project.default_branch || 'master'
@build_badge = Gitlab::Badge::Build.new(@project, @ref)
end
def update
if @project.update_attributes(update_params)
flash[:notice] = "CI/CD Pipelines settings for '#{@project.name}' was successfully updated."
redirect_to(
namespace_project_pipelines_settings_path(@project.namespace, @project),
notice: "CI/CD Pipelines settings for '#{@project.name}' was successfully updated."
)
else
render 'index'
end
end
private
def create_params
params.require(:pipeline).permit(:ref)
end
def update_params
params.require(:project).permit(
:runners_token, :builds_enabled, :build_allow_git_fetch, :build_timeout_in_minutes, :build_coverage_regex,
:public_builds
)
end
end
...@@ -25,7 +25,7 @@ class Projects::RefsController < Projects::ApplicationController ...@@ -25,7 +25,7 @@ class Projects::RefsController < Projects::ApplicationController
when "graphs_commits" when "graphs_commits"
commits_namespace_project_graph_path(@project.namespace, @project, @id) commits_namespace_project_graph_path(@project.namespace, @project, @id)
when "badges" when "badges"
settings_namespace_project_pipelines_path(@project.namespace, @project, ref: @id) namespace_project_pipelines_settings_path(@project.namespace, @project, ref: @id)
else else
namespace_project_commits_path(@project.namespace, @project, @id) namespace_project_commits_path(@project.namespace, @project, @id)
end end
......
...@@ -39,7 +39,7 @@ ...@@ -39,7 +39,7 @@
= link_to namespace_project_triggers_path(@project.namespace, @project), title: 'Triggers' do = link_to namespace_project_triggers_path(@project.namespace, @project), title: 'Triggers' do
%span %span
Triggers Triggers
= nav_link(controller: :pipelines) do = nav_link(controller: :pipelines_settings) do
= link_to settings_namespace_project_pipelines_path(@project.namespace, @project), title: 'CI/CD Pipelines' do = link_to namespace_project_pipelines_settings_path(@project.namespace, @project), title: 'CI/CD Pipelines' do
%span %span
CI/CD Pipelines CI/CD Pipelines
...@@ -7,7 +7,7 @@ ...@@ -7,7 +7,7 @@
.col-lg-9 .col-lg-9
%h5.prepend-top-0 %h5.prepend-top-0
Pipelines Pipelines
= form_for @project, url: settings_namespace_project_pipelines_path(@project.namespace.becomes(Namespace), @project), remote: true, authenticity_token: true do |f| = form_for @project, url: namespace_project_pipelines_settings_path(@project.namespace.becomes(Namespace), @project), remote: true, authenticity_token: true do |f|
%fieldset.builds-feature %fieldset.builds-feature
- unless @repository.gitlab_ci_yml - unless @repository.gitlab_ci_yml
.form-group .form-group
......
...@@ -732,7 +732,9 @@ Rails.application.routes.draw do ...@@ -732,7 +732,9 @@ Rails.application.routes.draw do
resources :triggers, only: [:index, :create, :destroy] resources :triggers, only: [:index, :create, :destroy]
resources :pipelines, only: [:index, :new, :create, :show] do resources :pipelines, only: [:index, :new, :create, :show] do
resource :settings, only: [:index, :update] collection do
resource :pipelines_settings, path: 'settings', only: [:show, :update]
end
member do member do
post :cancel post :cancel
......
require 'spec_helper'
feature "Pipelines settings", feature: true do
include GitlabRoutingHelper
let(:project) { create(:empty_project) }
let(:user) { create(:user) }
let(:role) { :developer }
background do
login_as(user)
project.team << [user, role]
visit namespace_project_pipelines_settings_path(project.namespace, project)
end
context 'for developer' do
given(:role) { :developer }
scenario 'to be disallowed to view' do
expect(page.status_code).to eq(404)
end
end
context 'for master' do
given(:role) { :master }
scenario 'be allowed to change' do
fill_in('Test coverage parsing', with: 'coverage_regex')
click_on 'Save changes'
expect(page.status_code).to eq(200)
expect(page).to have_field('Test coverage parsing', with: 'coverage_regex')
end
end
end
require 'spec_helper' require 'spec_helper'
feature "Pipelines", feature: true do describe "Pipelines" do
include GitlabRoutingHelper include GitlabRoutingHelper
let(:project) { create(:empty_project) } let(:project) { create(:empty_project) }
let(:user) { create(:user) } let(:user) { create(:user) }
let(:role) { :developer }
before do before do
login_as(user) login_as(user)
project.team << [user, role] project.team << [user, :developer]
end end
describe 'GET /:project/pipelines' do describe 'GET /:project/pipelines' do
...@@ -209,30 +208,4 @@ feature "Pipelines", feature: true do ...@@ -209,30 +208,4 @@ feature "Pipelines", feature: true do
it { expect(page).to have_content('Reference not found') } it { expect(page).to have_content('Reference not found') }
end end
end end
describe 'Pipelines settings' do
background do
visit settings_namespace_project_pipelines_path(project.namespace, project)
end
context 'for developer' do
given(:role) { :developer }
scenario 'to be disallowed to view' do
expect(page.status_code).to eq(404)
end
end
context 'for master' do
given(:role) { :master }
scenario 'be allowed to change' do
fill_in('Test coverage parsing', with: 'coverage_regex')
click_on 'Save changes'
expect(page.status_code).to eq(200)
expect(page).to have_field('Test coverage parsing', with: 'coverage_regex')
end
end
end
end end
...@@ -6,7 +6,7 @@ feature 'list of badges' do ...@@ -6,7 +6,7 @@ feature 'list of badges' do
project = create(:project) project = create(:project)
project.team << [user, :master] project.team << [user, :master]
login_as(user) login_as(user)
visit settings_namespace_project_pipelines_path(project.namespace, project) visit namespace_project_pipelines_settings_path(project.namespace, project)
end end
scenario 'user displays list of badges' do scenario 'user displays list of badges' do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment