check_apachedex_result: make sure threshold is of type float

/reviewed-on nexedi/slapos.toolbox!26

slapos/promise/check_apachedex_result/__init__.py

@@ -36,10 +36,9 @@ def checkApachedexResult(apachedex_path, apachedex_report_status_file, desired_t
           if m:
             apx_result=int(m[0])
             if apx_result > desired_threshold:
-              return 0,  "Thanks for keeping it all clean, result is " + str(apx_result)
+              return 0,  "Thanks for keeping it all clean, result is %s" % apx_result
             else:
-              return 1, "Threshold is lower than expected:  Expected was " + \
-                     str(desired_threshold) +" and current result is " + str(apx_result)
+              return 1, "Threshold is lower than expected:  Expected was %f and current result is %s" % (desired_threshold, apx_result)
         message = "No result found in the apdex file or the file is corrupted"
         break
 
@@ -56,7 +55,7 @@ def main():
   parser = argparse.ArgumentParser()
   parser.add_argument("--apachedex_path", required=True)
   parser.add_argument("--status_file", required=True)
-  parser.add_argument("--threshold", required=True)
+  parser.add_argument("--threshold", required=True, type=float)
   args = parser.parse_args()
 
   status, message = checkApachedexResult(args.apachedex_path, args.status_file, args.threshold)