slapos_erp5: fix Sale Invoice Transaction security

master/bt5/slapos_erp5/PortalTypeRolesTemplateItem/Sale%20Invoice%20Transaction.xml

@@ -10,7 +10,7 @@
    <property id='title'>ReadOnly for Accountant</property>
    <property id='condition'>python: context.getLedger("") == "automated"</property>
    <multi_property id='categories'>local_role_group/function</multi_property>
-   <multi_property id='category'>function/accounting</multi_property>
+   <multi_property id='category'>function/accounting*</multi_property>
    <multi_property id='base_category'>function</multi_property>
   </role>
   <role id='Auditor'>
@@ -20,11 +20,18 @@
    <multi_property id='categories'>local_role_group/user</multi_property>
    <multi_property id='base_category'>destination_section</multi_property>
   </role>
+  <role id='Assignee'>
+   <property id='title'>Writable for Accountant Agent</property>
+   <property id='condition'>python: context.getLedger("") != "automated"</property>
+   <multi_property id='categories'>local_role_group/function</multi_property>
+   <multi_property id='category'>function/accounting/agent</multi_property>
+   <multi_property id='base_category'>function</multi_property>
+  </role>
   <role id='Assignor'>
-   <property id='title'>Writable for Accountant</property>
+   <property id='title'>Writable for Accountant Manager</property>
    <property id='condition'>python: context.getLedger("") != "automated"</property>
    <multi_property id='categories'>local_role_group/function</multi_property>
-   <multi_property id='category'>function/accounting</multi_property>
+   <multi_property id='category'>function/accounting/manager</multi_property>
    <multi_property id='base_category'>function</multi_property>
   </role>
 </type_roles>
\ No newline at end of file

master/bt5/slapos_erp5/TestTemplateItem/portal_components/test.erp5.testSlapOSERP5GroupRoleSecurity.py

@@ -1413,13 +1413,25 @@ class TestPurchaseInvoiceTransaction(TestSlapOSGroupRoleSecurityMixin):
     self.assertRoles(product, self.user_id, ['Owner'])
 
 class TestSaleInvoiceTransaction(TestSlapOSGroupRoleSecurityMixin):
-  def test_GroupCompany(self):
+  def test_AccountingFunction_LedgerNotAutomated(self):
     product = self.portal.accounting_module.newContent(
         portal_type='Sale Invoice Transaction')
     product.updateLocalRolesOnSecurityGroups()
     self.assertSecurityGroup(product,
-        ['G-COMPANY', self.user_id, 'R-SHADOW-PERSON'], False)
-    self.assertRoles(product, 'G-COMPANY', ['Assignor'])
+        ['F-ACCMAN', 'F-ACCAGT', self.user_id], False)
+    self.assertRoles(product, 'F-ACCMAN', ['Assignor'])
+    self.assertRoles(product, 'F-ACCAGT', ['Assignee'])
+    self.assertRoles(product, self.user_id, ['Owner'])
+
+  def test_AccountingFunction_LedgerAutomated(self):
+    product = self.portal.accounting_module.newContent(
+        portal_type='Sale Invoice Transaction')
+    product.edit(ledger='automated')
+    product.updateLocalRolesOnSecurityGroups()
+    self.assertSecurityGroup(product,
+        ['F-ACCOUNTING*', self.user_id, 'R-SHADOW-PERSON'], False)
+    self.assertRoles(product, 'F-ACCOUNTING*', ['Auditor'])
+    self.assertRoles(product, 'R-SHADOW-PERSON', ['Assignee'])
     self.assertRoles(product, self.user_id, ['Owner'])
 
   def test_User(self):
@@ -1429,14 +1441,16 @@ class TestSaleInvoiceTransaction(TestSlapOSGroupRoleSecurityMixin):
     product = self.portal.accounting_module.newContent(
         portal_type='Sale Invoice Transaction')
     product.edit(
+        ledger='automated',
         destination_section_value=person,
         )
     product.updateLocalRolesOnSecurityGroups()
     self.assertSecurityGroup(product,
-        ['G-COMPANY', self.user_id, person.getUserId(), 
+        ['F-ACCOUNTING*', self.user_id, person.getUserId(),
          'R-SHADOW-PERSON'], False)
-    self.assertRoles(product, 'G-COMPANY', ['Assignor'])
+    self.assertRoles(product, 'F-ACCOUNTING*', ['Auditor'])
     self.assertRoles(product, person.getUserId(), ['Auditor'])
+    self.assertRoles(product, 'R-SHADOW-PERSON', ['Assignee'])
     self.assertRoles(product, self.user_id, ['Owner'])
 
 class TestServiceModule(TestSlapOSGroupRoleSecurityMixin):