See nexedi/erp5@28774376

By importing the new TimerService unconditionally,
the commit 34c81caf
(Timeout: introduce publisher_timeout configuration)
broke automatic site creation & publisher timeout
when the zope config specifies the old timerserver.

It makes to no sense to synchronize with the clock if there's nothing
after to remain synchronized.

[erp5_ingestion] Do not use absolute URL parameter
This is not compatible with ERP5JS

This is a fix for 5eeb52d5. Waitress
also requires a cancel method. Not having one raises an uncaught
AttributeError.

otherwise min / max criterion does not work.

Fix remaining functional test failures and drop a few more code that become unused now that we have a `setFile` command.

Because firefox 68 executes event handlers for events triggered on disabled elements ( https://phabricator.services.mozilla.com/D10000 ), Zelenium is also adapted to mimic the behaviour we had with firefox 52 (and chrome behavior) of not executing event hander.

TODO:
 * [x] `testContributeTab` sometimes displays Converted, sometimes Converting. I wonder if we can wait for something to make the test deterministic, otherwise we can assert a regexp.
 * [x] `erp5_web_renderjs_ui_test:testFunctionalRJSCore` ( discussed in 05b9c4af (comment 87278) )
 * [x] someone update test nodes to use new firefox.
 * [x] understand why with firefox 58 selenium sends clicks on disabled button.

/reviewed-on !922

Volatile attributes may disappear from one statement to the next.
Make code reliable by moving it one level up the call stack, removing the
need for volatile attributes.
_setId and _postCopy get back to their original "copy of OFS.CopySupport"
status (see comment at beginning of file).

This BT contains the same category twice.

Bank Account, Currency{, Module}, Currency Exchange {Cell,Line} already
exist in erp5_base, which is a dependency of this Business Template at
least through erp5_trade.
"composition" and "variation" Base Categories exist in erp5_pdm, which
is a dependency of this Business Template via erp5_trade.
"site" Base Category exists in erp5_base, which is a dependency of this
Business Template via erp5_trade.

classification is already provided by erp5_dms, which is a dependency
of this BT already.

requirement is also present in erp5_project. So add a dependency on that BT
and remove the duplication.

This BT achieved the rare feat of containing the same document twice.

region/europe/western_europe is also present in erp5_tiosafe_test, which is
already installed in the same unit test. So add a dependency on that BT and
remove the duplication.

currency_module/euro is also present in erp5_tiosafe_test, which is already
installed in the same unit test. So add a dependency on that BT and remove
the duplication.

Vincent Pelletier:
- Disable timeout by default.

Vincent Pelletier:
- Ignore TimerService-originated publication requests.
- Add copyright headers.
- Disable timeout by default.
- Give a meaning to requested negative deadlines.
- Docstrings.
- Assorted simplifications.

The Assigments are only relevant if the User is based on Person Document, on SlapOS, an user come from a Computer or a Software Instance Document. This change makes the document compatible with other kinds of Users, as Assigment is overkill for Non-Person cases, as the presence of ERP5 Login is enough to determinate the User existence. 

The other alternative would be re-factorize to not duplicate code, which seems not the intention of how this code was written. 

/cc @jerome, @kazuhiko 



/reviewed-on nexedi/erp5!458

Simpler, and reduces the exposure of exc_info (which can be tricky to use
in other contexts).

When we updated Firefox from 52 to 68, the behavior of firefox changed.
With 52, when calling element.dispatchEvent on a disabled element, the
event handlers were not executed, but in 68 they are.

Unlike Medusa, WSGI does not do it.

Both the dummy method_id and the actually-used grouping_method_id.

Without this commit, it felt back to the timerserver egg.

 * Depending on conversion server speed, document will be Converted or
Converting. Assert that the state match Convert(ing|ed) to accept both.
 * prefer assert* instead of verify* to terminate test execution on
first failed assertion.
 * use more specific xpath instead of asserting that text is present in
the page.
 * checking that URL matches the previous URL interpreted as a regexp
was not working for IPv6 URL with brackets (because of the meaning of
regular expression). Because what we want here is to check that URL
starts with previously stored URL, check with a glob: expression, that
should be also compatible with IPv6 URLs.

Rename the test for PDFJS introduced in
b58995c9 to testCheckPDFPreview

Repair original testCheckPDFThumbnail by updating the link name from
Preview to Thumbnail, as a follow up to fe83821b