- 06 Aug, 2019 14 commits
-
-
Vincent Pelletier authored
-
Vincent Pelletier authored
-
Vincent Pelletier authored
These activities may already be running, and deleting them would cause validation node to violate activity dependencies. For example, already-running indexation activities will not be waited upon, causing the unindexation activity spawned below to potentially finish before ongoing indexation, leading to a catalog persistently inconsistent with object database. If these activities are not already running, then CMFActivity will anyway discard them upon discovering that their execution context does not exist. And if these activities are failed, then it is a site maintenance issue (one should not keep failed activities for too long) and must not be a common case, and not really worthy of handling here. Also, rework a CMFActivity test checking that activties already-spawned on a later-deleted context get discarded instead of being executed. Previous test implementation order was to work around the activity deletion removed in this commit. The implementation used here is more natural.
-
Vincent Pelletier authored
-
Vincent Pelletier authored
-
Vincent Pelletier authored
As a consequence, reduces portal type duplication: Solver Tool portal type is also present in erp5_simulation, and does not work without it installed. Also, install erp5_simulation before erp5_trade in tests. Note for testFunctionalKM: not moving erp5_simulation_test as this BT also depends on erp5_trade and not just erp5_simulation.
-
Vincent Pelletier authored
trade_phase/production is already present in erp5_mrp. Add a dependency to it, and remove it from this Business Template. trade_phase/production/delivery: Likewise. Also, remove the test-dependency to erp5_mrp as it's now a regular dependency.
-
Vincent Pelletier authored
This BT contains the same category twice.
-
Vincent Pelletier authored
Bank Account, Currency{, Module}, Currency Exchange {Cell,Line} already exist in erp5_base, which is a dependency of this Business Template at least through erp5_trade. "composition" and "variation" Base Categories exist in erp5_pdm, which is a dependency of this Business Template via erp5_trade. "site" Base Category exists in erp5_base, which is a dependency of this Business Template via erp5_trade.
-
Vincent Pelletier authored
classification is already provided by erp5_dms, which is a dependency of this BT already.
-
Vincent Pelletier authored
requirement is also present in erp5_project. So add a dependency on that BT and remove the duplication.
-
Vincent Pelletier authored
This BT achieved the rare feat of containing the same document twice.
-
Vincent Pelletier authored
region/europe/western_europe is also present in erp5_tiosafe_test, which is already installed in the same unit test. So add a dependency on that BT and remove the duplication.
-
Vincent Pelletier authored
currency_module/euro is also present in erp5_tiosafe_test, which is already installed in the same unit test. So add a dependency on that BT and remove the duplication.
-
- 05 Aug, 2019 1 commit
-
-
Georgios Dagkakis authored
-
- 02 Aug, 2019 8 commits
-
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
otherwise naturalWidth/naturalHeight may be 0
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
-
- 01 Aug, 2019 3 commits
-
-
Romain Courteaud authored
Domains are not meant to display too many documents at the same level.
-
Romain Courteaud authored
Domains are not meant to display too many documents at the same level.
-
Romain Courteaud authored
Domains are not meant to display too many documents at the same level.
-
- 31 Jul, 2019 2 commits
-
-
Bryton Lacquement authored
/reviewed-on nexedi/erp5!830
-
Vincent Pelletier authored
Avoids accumulating useless connections when a single test file contains multiple files.
-
- 30 Jul, 2019 1 commit
-
-
Romain Courteaud authored
Sorting on all documents is a performance killer. In case no query parameter is available, do not trigger any allDocs calculation and do not display the listbox, as results would be meaningless.
-
- 29 Jul, 2019 2 commits
-
-
Tristan Cavelier authored
-
Tristan Cavelier authored
For instance, typing a backslash in a relation field does not crash the ui anymore. /bug #20180123-D78557 https://nexedijs.erp5.net/#/bug_module/20180123-D78557
-
- 26 Jul, 2019 4 commits
-
-
Romain Courteaud authored
-
Boxiang Sun authored
-
Boxiang Sun authored
-
Vincent Pelletier authored
-
- 25 Jul, 2019 4 commits
-
-
Vincent Pelletier authored
This property is only conditionally set, which causes distracting error when something goes wrong. If we really want to check that the expected code path was followed there has to be a better check and a more debugging- friendly error than an AttributeError.
-
Vincent Pelletier authored
While such activity parameter combination does not make sense, it is technically possible to spawn activities with a group_id set but without a grouping_method_id. The consequence is zombie activities: they never fail, do not prevent other activities from being executed, but and are permanently run on the node which reserved more than one because: - all but one activity is in MESSAGE_NOT_EXECUTED state, forcing an abort - finalizeMessageExecution does not understand that MESSAGE_NOT_EXECUTED activities may not have failed, and itself fail while trying to detect the failure type (ConflictError vs. others), failing to free & postpone the activity, in turn failing to bring it to eventually permanent failure state. Make those conditions consistent, and use tuple-unpacking to detect any future inconsistency much earlier, simplifying debugging.
-
Vincent Pelletier authored
group_method_id column is declared "NOT NULL", so it can only be None if getProcessableMessageList could not find any activity, in which case this code is not executed ("if message_list" is false). This simplifies two "if" statements.
-
Vincent Pelletier authored
-
- 23 Jul, 2019 1 commit
-
-
Sebastien Robin authored
-