- 30 Mar, 2016 9 commits
-
-
Kevin Modzelewski authored
Copy over tp_new_wrapper, which is the main thing that should be doing the check. Our implementation was pretty much the same minus that check. There's also a separate check that isn't completely necessary but seems like a good idea, and we had it on certain codepaths, and whether you hit it depended on whether you were in CAPI mode or not.
-
Kevin Modzelewski authored
-
Kevin Modzelewski authored
-
Kevin Modzelewski authored
-
Kevin Modzelewski authored
It will end up spitting out something like: %x = callattrCapi() Py_XDECREF(x) if (!x) throwCapiException() We usually write something more like: %x = callattrCapi() if (!x) throwCapiException() Py_DECREF(x) But with optimizations turned on, llvm will turn them into the same thing.
-
Marius Wachtler authored
-
Marius Wachtler authored
-
Marius Wachtler authored
-
Kevin Modzelewski authored
-
- 29 Mar, 2016 29 commits
-
-
Kevin Modzelewski authored
-
Kevin Modzelewski authored
-
Kevin Modzelewski authored
-
Kevin Modzelewski authored
-
Kevin Modzelewski authored
-
Kevin Modzelewski authored
-
Kevin Modzelewski authored
-
Kevin Modzelewski authored
-
Kevin Modzelewski authored
-
Kevin Modzelewski authored
-
Kevin Modzelewski authored
We would incref them before putting them into the args array. Now we keep some extra information during the rewriting process, which lets rearrangeArguments say whether any of the values need to be decreffed. It's pretty rare that they need to so I think this should be some nice savings (20% on a specifically-targeted microbenchmark, no change on raytrace.py). I'm a little bit worried though that since it is so rare to need to do the decref, it would be easy to forget to check for it. Well I think we already were forgetting it in some places... but at least now it's an explicit arg you have to manage so maybe it's less likely to cause mistakes.
-
Kevin Modzelewski authored
-
Kevin Modzelewski authored
-
Kevin Modzelewski authored
-
Kevin Modzelewski authored
-
Kevin Modzelewski authored
-
Marius Wachtler authored
-
Kevin Modzelewski authored
-
Kevin Modzelewski authored
-
Kevin Modzelewski authored
-
Kevin Modzelewski authored
-
Kevin Modzelewski authored
-
Kevin Modzelewski authored
-
Kevin Modzelewski authored
-
Kevin Modzelewski authored
-
Kevin Modzelewski authored
-
Kevin Modzelewski authored
-
Kevin Modzelewski authored
-
Kevin Modzelewski authored
-
- 28 Mar, 2016 2 commits
-
-
Kevin Modzelewski authored
- change up interpreter-shutdown to better deal with objects with custom finalizers - fix a bunch of mixed decrefs for oldstyle-classes - a couple other misc things file.py is now working
-
Kevin Modzelewski authored
-