groups_spec.rb 5.47 KB
Newer Older
1 2
require 'spec_helper'

3
feature 'Group', feature: true do
4 5 6 7
  before do
    login_as(:admin)
  end

8 9 10 11 12 13
  matcher :have_namespace_error_message do
    match do |page|
      page.has_content?("Path can contain only letters, digits, '_', '-' and '.'. Cannot start with '-' or end in '.', '.git' or '.atom'.")
    end
  end

14 15
  describe 'create a group' do
    before { visit new_group_path }
16

17 18 19 20
    describe 'with space in group path' do
      it 'renders new group form with validation errors' do
        fill_in 'Group path', with: 'space group'
        click_button 'Create group'
21

22 23 24
        expect(current_path).to eq(groups_path)
        expect(page).to have_namespace_error_message
      end
25 26
    end

27 28 29 30
    describe 'with .atom at end of group path' do
      it 'renders new group form with validation errors' do
        fill_in 'Group path', with: 'atom_group.atom'
        click_button 'Create group'
31

32 33 34
        expect(current_path).to eq(groups_path)
        expect(page).to have_namespace_error_message
      end
35 36
    end

37 38 39 40
    describe 'with .git at end of group path' do
      it 'renders new group form with validation errors' do
        fill_in 'Group path', with: 'git_group.git'
        click_button 'Create group'
41

42 43 44
        expect(current_path).to eq(groups_path)
        expect(page).to have_namespace_error_message
      end
45
    end
46 47 48

    describe 'Mattermost team creation' do
      before do
49
        stub_mattermost_setting(enabled: mattermost_enabled)
50

51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83
        visit new_group_path
      end

      context 'Mattermost enabled' do
        let(:mattermost_enabled) { true }

        it 'displays a team creation checkbox' do
          expect(page).to have_selector('#group_create_chat_team')
        end

        it 'checks the checkbox by default' do
          expect(find('#group_create_chat_team')['checked']).to eq(true)
        end

        it 'updates the team URL on graph path update', :js do
          out_span = find('span[data-bind-out="create_chat_team"]')

          expect(out_span.text).to be_empty

          fill_in('group_path', with: 'test-group')

          expect(out_span.text).to eq('test-group')
        end
      end

      context 'Mattermost disabled' do
        let(:mattermost_enabled) { false }

        it 'doesnt show a team creation checkbox if Mattermost not enabled' do
          expect(page).not_to have_selector('#group_create_chat_team')
        end
      end
    end
84 85
  end

86
  describe 'create a nested group', js: true do
87 88
    let(:group) { create(:group, path: 'foo') }

89 90 91 92 93 94 95 96 97 98 99 100 101
    context 'as admin' do
      before do
        visit subgroups_group_path(group)
        click_link 'New Subgroup'
      end

      it 'creates a nested group' do
        fill_in 'Group path', with: 'bar'
        click_button 'Create group'

        expect(current_path).to eq(group_path('foo/bar'))
        expect(page).to have_content("Group 'bar' was successfully created.")
      end
102 103
    end

104 105
    context 'as group owner' do
      let(:user) { create(:user) }
106

107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122
      before do
        group.add_owner(user)
        logout
        login_as(user)

        visit subgroups_group_path(group)
        click_link 'New Subgroup'
      end

      it 'creates a nested group' do
        fill_in 'Group path', with: 'bar'
        click_button 'Create group'

        expect(current_path).to eq(group_path('foo/bar'))
        expect(page).to have_content("Group 'bar' was successfully created.")
      end
123 124 125
    end
  end

126 127 128 129 130 131 132 133 134 135
  it 'checks permissions to avoid exposing groups by parent_id' do
    group = create(:group, :private, path: 'secret-group')

    logout
    login_as(:user)
    visit new_group_path(parent_id: group.id)

    expect(page).not_to have_content('secret-group')
  end

136
  describe 'group edit' do
137 138
    let(:group) { create(:group) }
    let(:path)  { edit_group_path(group) }
139
    let(:new_name) { 'new-name' }
140

141
    before { visit path }
142

143 144
    it 'saves new settings' do
      fill_in 'group_name', with: new_name
145 146 147
      click_button 'Save group'

      expect(page).to have_content 'successfully updated'
148 149 150 151 152
      expect(find('#group_name').value).to eq(new_name)

      page.within ".navbar-gitlab" do
        expect(page).to have_content new_name
      end
153 154 155
    end

    it 'removes group' do
156
      click_link 'Remove group'
157 158 159 160 161

      expect(page).to have_content "scheduled for deletion"
    end
  end

162
  describe 'group page with markdown description' do
163 164 165 166 167
    let(:group) { create(:group) }
    let(:path)  { group_path(group) }

    it 'parses Markdown' do
      group.update_attribute(:description, 'This is **my** group')
168

169
      visit path
170

171
      expect(page).to have_css('.group-home-desc > p > strong')
172 173 174 175
    end

    it 'passes through html-pipeline' do
      group.update_attribute(:description, 'This group is the :poop:')
176

177
      visit path
178

Eric Eastwood's avatar
Eric Eastwood committed
179
      expect(page).to have_css('.group-home-desc > p > gl-emoji')
180 181 182 183
    end

    it 'sanitizes unwanted tags' do
      group.update_attribute(:description, '# Group Description')
184

185
      visit path
186

187
      expect(page).not_to have_css('.group-home-desc h1')
188 189 190 191
    end

    it 'permits `rel` attribute on links' do
      group.update_attribute(:description, 'https://google.com/')
192

193
      visit path
194

195
      expect(page).to have_css('.group-home-desc a[rel]')
196 197
    end
  end
198 199 200 201 202 203 204 205

  describe 'group page with nested groups', js: true do
    let!(:group) { create(:group) }
    let!(:nested_group) { create(:group, parent: group) }
    let!(:path)  { group_path(group) }

    it 'has nested groups tab with nested groups inside' do
      visit path
206
      click_link 'Subgroups'
207

208
      expect(page).to have_content(nested_group.name)
209 210
    end
  end
211
end