changelogs/unreleased/blackst0ne-replace-sidekiq-inline-with-perform-enqueued-jobs.yml · ddd2a25679f1d875332f603f115e25577b05a5a2 · Boxiang Sun / gitlab-ce

You need to sign in or sign up before continuing.

Replace 'Sidekiq::Testing.inline!' with 'perform_enqueued_jobs' · ddd2a256

blackst0ne authored Jul 23, 2018

`perform_enqueued_jobs` is a Sidekiq method.
Using this method violates the Dependency inversion principle[0].

This commit replaces `perform_enqueued_jobs` with ActiveJob's abstract
method `perform_enqueued_jobs` in specs.

[0]: https://en.wikipedia.org/wiki/Dependency_inversion_principle

ddd2a256

blackst0ne-replace-sidekiq-inline-with-perform-enqueued-jobs.yml 130 Bytes

Replace blackst0ne-replace-sidekiq-inline-with-perform-enqueued-jobs.yml