Improve efficiency of authorized_runner policy query

18821b15 · Dylan Griffith · 7320684c · 18821b15
Commit 18821b15 authored May 09, 2018 by Dylan Griffith
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

app/policies/ci/runner_policy.rb app/policies/ci/runner_policy.rb +1 -1

No files found.
--- a/app/policies/ci/runner_policy.rb
+++ b/app/policies/ci/runner_policy.rb
@@ -3,7 +3,7 @@ module Ci
    with_options scope: :subject, score: 0
    condition(:locked, scope: :subject) { @subject.locked? }

-    condition(:authorized_runner) { @user.ci_authorized_runners.include?(@subject) }
+    condition(:authorized_runner) { @user.ci_authorized_runners.exists?(@subject.id) }

    rule { anonymous }.prevent_all
    rule { admin | authorized_runner }.enable :assign_runner