Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
199e31eb
Commit
199e31eb
authored
Apr 10, 2018
by
Grzegorz Bizon
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Extend specs for detailed build extended statuses
parent
160ffb68
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
46 additions
and
6 deletions
+46
-6
lib/gitlab/ci/status/build/factory.rb
lib/gitlab/ci/status/build/factory.rb
+3
-3
spec/lib/gitlab/ci/status/build/common_spec.rb
spec/lib/gitlab/ci/status/build/common_spec.rb
+6
-0
spec/lib/gitlab/ci/status/build/empty_spec.rb
spec/lib/gitlab/ci/status/build/empty_spec.rb
+31
-0
spec/lib/gitlab/ci/status/build/factory_spec.rb
spec/lib/gitlab/ci/status/build/factory_spec.rb
+6
-3
No files found.
lib/gitlab/ci/status/build/factory.rb
View file @
199e31eb
...
...
@@ -9,7 +9,8 @@ module Gitlab
Status
::
Build
::
Canceled
,
Status
::
Build
::
Created
,
Status
::
Build
::
Pending
,
Status
::
Build
::
Skipped
],
Status
::
Build
::
Skipped
,
Status
::
Build
::
Empty
],
[
Status
::
Build
::
Cancelable
,
Status
::
Build
::
Retryable
],
[
Status
::
Build
::
Failed
],
...
...
@@ -17,8 +18,7 @@ module Gitlab
Status
::
Build
::
Play
,
Status
::
Build
::
Stop
],
[
Status
::
Build
::
Action
],
[
Status
::
Build
::
Retried
],
[
Status
::
Build
::
Empty
]]
[
Status
::
Build
::
Retried
]]
end
def
self
.
common_helpers
...
...
spec/lib/gitlab/ci/status/build/common_spec.rb
View file @
199e31eb
...
...
@@ -38,4 +38,10 @@ describe Gitlab::Ci::Status::Build::Common do
expect
(
subject
.
details_path
).
to
include
"jobs/
#{
build
.
id
}
"
end
end
describe
'#illustration'
do
it
'provides a fallback empty state illustration'
do
expect
(
subject
.
illustration
).
not_to
be_empty
end
end
end
spec/lib/gitlab/ci/status/build/empty_spec.rb
0 → 100644
View file @
199e31eb
require
'spec_helper'
describe
Gitlab
::
Ci
::
Status
::
Build
::
Empty
do
let
(
:build
)
{
create
(
:ci_build
,
:running
)
}
let
(
:status
)
{
double
(
'core status'
)
}
let
(
:user
)
{
double
(
'user'
)
}
subject
{
described_class
.
new
(
status
)
}
describe
'#illustration'
do
it
'provides an empty state illustration'
do
expect
(
subject
.
illustration
).
not_to
be_empty
end
end
describe
'.matches?'
do
subject
{
described_class
.
matches?
(
build
,
user
)
}
context
'when a build has trace'
do
let
(
:build
)
{
create
(
:ci_build
,
:trace_artifact
)
}
it
{
is_expected
.
to
be_falsy
}
end
context
'with a build that has not been retried'
do
let
(
:build
)
{
create
(
:ci_build
,
:running
)
}
it
{
is_expected
.
to
be_truthy
}
end
end
end
spec/lib/gitlab/ci/status/build/factory_spec.rb
View file @
199e31eb
...
...
@@ -75,7 +75,9 @@ describe Gitlab::Ci::Status::Build::Factory do
it
'matches correct extended statuses'
do
expect
(
factory
.
extended_statuses
)
.
to
eq
[
Gitlab
::
Ci
::
Status
::
Build
::
Retryable
,
Gitlab
::
Ci
::
Status
::
Build
::
Failed
]
.
to
eq
[
Gitlab
::
Ci
::
Status
::
Build
::
Empty
,
Gitlab
::
Ci
::
Status
::
Build
::
Retryable
,
Gitlab
::
Ci
::
Status
::
Build
::
Failed
]
end
it
'fabricates a failed build status'
do
...
...
@@ -94,7 +96,7 @@ describe Gitlab::Ci::Status::Build::Factory do
end
context
'when build is allowed to fail'
do
let
(
:build
)
{
create
(
:ci_build
,
:failed
,
:allowed_to_fail
)
}
let
(
:build
)
{
create
(
:ci_build
,
:failed
,
:allowed_to_fail
,
:trace_artifact
)
}
it
'matches correct core status'
do
expect
(
factory
.
core_status
).
to
be_a
Gitlab
::
Ci
::
Status
::
Failed
...
...
@@ -160,7 +162,8 @@ describe Gitlab::Ci::Status::Build::Factory do
it
'matches correct extended statuses'
do
expect
(
factory
.
extended_statuses
)
.
to
eq
[
Gitlab
::
Ci
::
Status
::
Build
::
Cancelable
]
.
to
eq
[
Gitlab
::
Ci
::
Status
::
Build
::
Empty
,
Gitlab
::
Ci
::
Status
::
Build
::
Cancelable
]
end
it
'fabricates a canceable build status'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment