Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
401a2ec0
Commit
401a2ec0
authored
Dec 09, 2016
by
Filipa Lacerda
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Adds tests to prevent future errors.
Fix undefined variable in es5
parent
7c9a85e3
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
42 additions
and
2 deletions
+42
-2
app/assets/javascripts/pipelines.js.es6
app/assets/javascripts/pipelines.js.es6
+1
-1
changelogs/unreleased/25483-broken-tabs.yml
changelogs/unreleased/25483-broken-tabs.yml
+1
-1
spec/javascripts/fixtures/pipeline_graph.html.haml
spec/javascripts/fixtures/pipeline_graph.html.haml
+15
-0
spec/javascripts/pipelines_spec.js.es6
spec/javascripts/pipelines_spec.js.es6
+25
-0
No files found.
app/assets/javascripts/pipelines.js.es6
View file @
401a2ec0
...
...
@@ -16,7 +16,7 @@
addMarginToBuildColumns() {
this.pipelineGraph = document.querySelector('.pipeline-graph');
const secondChildBuildNodes = document.querySelector('.pipeline-graph').querySelectorAll('.build:nth-child(2)');
for (buildNodeIndex in secondChildBuildNodes) {
for (
const
buildNodeIndex in secondChildBuildNodes) {
const buildNode = secondChildBuildNodes[buildNodeIndex];
const firstChildBuildNode = buildNode.previousElementSibling;
if (!firstChildBuildNode || !firstChildBuildNode.matches('.build')) continue;
...
...
changelogs/unreleased/25483-broken-tabs.yml
View file @
401a2ec0
---
title
:
Fix TypeError
:
Cannot read property 'initTabs' on commit builds tab
merge_request
:
merge_request
:
8009
author
:
spec/javascripts/fixtures/pipeline_graph.html.haml
0 → 100644
View file @
401a2ec0
%div
.pipeline-visualization.pipeline-graph
%ul
.stage-column-list
%li
.stage-column
.stage-name
%a
{
:href
=>
"/"
}
Test
.builds-container
%ul
%li
.build
.curve
.build-content
%a
%svg
.ci-status-text
stop_review
spec/javascripts/pipelines_spec.js.es6
0 → 100644
View file @
401a2ec0
//= require pipelines
(() => {
describe('Pipelines', () => {
fixture.preload('pipeline_graph');
beforeEach(() => {
fixture.load('pipeline_graph');
});
it('should be defined', () => {
expect(window.gl.Pipelines).toBeDefined();
});
it('should create a `Pipelines` instance without options', () => {
expect(() => { new window.gl.Pipelines(); }).not.toThrow(); //eslint-disable-line
});
it('should create a `Pipelines` instance with options', () => {
const pipelines = new window.gl.Pipelines({ foo: 'bar' });
expect(pipelines.pipelineGraph).toBeDefined();
});
});
})();
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment