Merge branch 'conv-dev-index-regression' into 'master'

Correctly associate ConvDev Index nav link with its controller

Closes #37583

See merge request !14124

app/views/layouts/nav/sidebar/_admin.html.haml

@@ -6,7 +6,7 @@
           = icon('wrench')
         .sidebar-context-title Admin Area
     %ul.sidebar-top-level-items
-      = nav_link(controller: %w(dashboard admin projects users groups jobs runners cohorts), html_options: {class: 'home'}) do
+      = nav_link(controller: %w(dashboard admin projects users groups jobs runners cohorts conversational_development_index), html_options: {class: 'home'}) do
         = sidebar_link admin_root_path, title: _('Overview'), css: 'shortcuts-tree' do
           .nav-icon-container
             = custom_icon('overview')
@@ -14,7 +14,7 @@
             Overview
 
         %ul.sidebar-sub-level-items
-          = nav_link(controller: %w(dashboard admin projects users groups jobs runners cohorts), html_options: { class: "fly-out-top-item" } ) do
+          = nav_link(controller: %w(dashboard admin projects users groups jobs runners cohorts conversational_development_index), html_options: { class: "fly-out-top-item" } ) do
             = link_to admin_root_path do
               %strong.fly-out-top-item-name
                 #{ _('Overview') }
@@ -52,16 +52,16 @@
               %span
                 ConvDev Index
 
-      = nav_link(controller: %w(conversational_development_index system_info background_jobs logs health_check requests_profiles)) do
-        = sidebar_link admin_conversational_development_index_path, title: _('Monitoring') do
+      = nav_link(controller: %w(system_info background_jobs logs health_check requests_profiles)) do
+        = sidebar_link admin_system_info_path, title: _('Monitoring') do
           .nav-icon-container
             = custom_icon('monitoring')
           %span.nav-item-name
             Monitoring
 
         %ul.sidebar-sub-level-items
-          = nav_link(controller: %w(conversational_development_index system_info background_jobs logs health_check requests_profiles), html_options: { class: "fly-out-top-item" } ) do
-            = link_to admin_conversational_development_index_path do
+          = nav_link(controller: %w(system_info background_jobs logs health_check requests_profiles), html_options: { class: "fly-out-top-item" } ) do
+            = link_to admin_system_info_path do
               %strong.fly-out-top-item-name
                 #{ _('Monitoring') }
           %li.divider.fly-out-top-item

changelogs/unreleased/conv-dev-index-regression.yml

+---
+title: Fix ConvDev Index nav item and Monitoring submenu regression
+merge_request: !14124
+author:
+type: fixed

doc/user/admin_area/monitoring/convdev.md

@@ -23,7 +23,7 @@ If you have just started using GitLab, it may take a few weeks for data to be
 collected before this feature is available.
 
 This feature is accessible only to a system admin, at
-**Admin area > Monitoring > ConvDev Index**.
+**Admin area > Overview > ConvDev Index**.
 
 [ce-30469]: https://gitlab.com/gitlab-org/gitlab-ce/issues/30469
 [ping]: ../settings/usage_statistics.md#usage-ping