Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
4b463dcb
Commit
4b463dcb
authored
May 09, 2017
by
Sean McGivern
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix links in code review docs
parent
eb61b3b3
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
10 additions
and
5 deletions
+10
-5
doc/development/code_review.md
doc/development/code_review.md
+10
-5
No files found.
doc/development/code_review.md
View file @
4b463dcb
...
...
@@ -6,18 +6,20 @@ There are a few rules to get your merge request accepted:
1.
Your merge request should only be
**merged by a [maintainer][team]**
.
1.
If your merge request includes only backend changes [^1], it must be
**approved by a [backend maintainer][
team
]**
.
**approved by a [backend maintainer][
projects
]**
.
1.
If your merge request includes only frontend changes [^1], it must be
**approved by a [frontend maintainer][
team
]**
.
**approved by a [frontend maintainer][
projects
]**
.
1.
If your merge request includes frontend and backend changes [^1], it must
be
**approved by a [frontend and a backend maintainer][
team
]**
.
be
**approved by a [frontend and a backend maintainer][
projects
]**
.
1.
To lower the amount of merge requests maintainers need to review, you can
ask or assign any
[
reviewers
][
team
]
for a first review.
ask or assign any
[
reviewers
][
projects
]
for a first review.
1.
If you need some guidance (e.g. it's your first merge request), feel free
to ask one of the
[
Merge request coaches
][
team
]
.
1.
The reviewer will assign the merge request to a maintainer once the
reviewer is satisfied with the state of the merge request.
For more guidance, see
[
CONTRIBUTING.md
](
https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md
)
.
## Best practices
This guide contains advice and best practices for performing code review, and
...
...
@@ -30,7 +32,7 @@ code is effective, understandable, and maintainable.
Any developer can, and is encouraged to, perform code review on merge requests
of colleagues and contributors. However, the final decision to accept a merge
request is up to one the project's maintainers, denoted on the
[
team page
](
https://about.gitlab.com/team
)
.
[
engineering projects
][
projects
]
.
### Everyone
...
...
@@ -140,3 +142,6 @@ Largely based on the [thoughtbot code review guide].
---
[
Return to Development documentation
](
README.md
)
[
projects
]:
https://about.gitlab.com/handbook/engineering/projects/
[
team
]:
https://about.gitlab.com/team/
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment