Merge branch '38869-start' into 'master'

Enable eslint in star and remove from main.js

See merge request gitlab-org/gitlab-ce!14795

app/assets/javascripts/main.js

@@ -116,7 +116,6 @@ import './right_sidebar';
 import './search';
 import './search_autocomplete';
 import './smart_interval';
-import './star';
 import './subscription';
 import './subscription_select';
 import initBreadcrumbs from './breadcrumb';

app/assets/javascripts/star.js

-/* eslint-disable func-names, space-before-function-paren, wrap-iife, no-unused-vars, one-var, no-var, one-var-declaration-per-line, prefer-arrow-callback, no-new, max-len */
 import Flash from './flash';
 import { __, s__ } from './locale';
 
 export default class Star {
   constructor() {
-    $('.project-home-panel .toggle-star').on('ajax:success', function(e, data, status, xhr) {
-      var $starIcon, $starSpan, $this, toggleStar;
-      $this = $(this);
-      $starSpan = $this.find('span');
-      $starIcon = $this.find('i');
-      toggleStar = function(isStarred) {
-        $this.parent().find('.star-count').text(data.star_count);
-        if (isStarred) {
-          $starSpan.removeClass('starred').text(s__('StarProject|Star'));
-          $starIcon.removeClass('fa-star').addClass('fa-star-o');
-        } else {
-          $starSpan.addClass('starred').text(__('Unstar'));
-          $starIcon.removeClass('fa-star-o').addClass('fa-star');
+    $('.project-home-panel .toggle-star')
+      .on('ajax:success', function handleSuccess(e, data) {
+        const $this = $(this);
+        const $starSpan = $this.find('span');
+        const $starIcon = $this.find('i');
+
+        function toggleStar(isStarred) {
+          $this.parent().find('.star-count').text(data.star_count);
+          if (isStarred) {
+            $starSpan.removeClass('starred').text(s__('StarProject|Star'));
+            $starIcon.removeClass('fa-star').addClass('fa-star-o');
+          } else {
+            $starSpan.addClass('starred').text(__('Unstar'));
+            $starIcon.removeClass('fa-star-o').addClass('fa-star');
+          }
         }
-      };
-      toggleStar($starSpan.hasClass('starred'));
-    }).on('ajax:error', function(e, xhr, status, error) {
-      new Flash('Star toggle failed. Try again later.', 'alert');
-    });
+
+        toggleStar($starSpan.hasClass('starred'));
+      })
+      .on('ajax:error', () => {
+        Flash('Star toggle failed. Try again later.', 'alert');
+      });
   }
 }