Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
58b05a6e
Commit
58b05a6e
authored
Nov 16, 2017
by
Mike Greiling
Committed by
Phil Hughes
Nov 16, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Resolve "Clicking on GPG verification badge jumps to top of the page"
parent
a248bb76
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
8 additions
and
2 deletions
+8
-2
app/views/projects/commit/_ajax_signature.html.haml
app/views/projects/commit/_ajax_signature.html.haml
+1
-1
app/views/projects/commit/_signature_badge.html.haml
app/views/projects/commit/_signature_badge.html.haml
+1
-1
changelogs/unreleased/40198-fix-gpg-badge-links.yml
changelogs/unreleased/40198-fix-gpg-badge-links.yml
+6
-0
No files found.
app/views/projects/commit/_ajax_signature.html.haml
View file @
58b05a6e
-
if
commit
.
has_signature?
%a
{
href:
'
#
'
,
tabindex:
0
,
class:
commit_signature_badge_classes
(
'js-loading-gpg-badge'
),
data:
{
toggle:
'tooltip'
,
placement:
'auto top'
,
title:
'GPG signature (loading...)'
,
'commit-sha'
=>
commit
.
sha
}
}
%a
{
href:
'
javascript:void(0)
'
,
tabindex:
0
,
class:
commit_signature_badge_classes
(
'js-loading-gpg-badge'
),
data:
{
toggle:
'tooltip'
,
placement:
'auto top'
,
title:
'GPG signature (loading...)'
,
'commit-sha'
=>
commit
.
sha
}
}
app/views/projects/commit/_signature_badge.html.haml
View file @
58b05a6e
...
...
@@ -24,5 +24,5 @@
=
link_to
(
'Learn more about signing commits'
,
help_page_path
(
'user/project/repository/gpg_signed_commits/index.md'
),
class:
'gpg-popover-help-link'
)
%a
{
href:
'
#
'
,
tabindex:
0
,
class:
css_classes
,
data:
{
toggle:
'popover'
,
html:
'true'
,
placement:
'auto top'
,
title:
title
,
content:
content
}
}
%a
{
href:
'
javascript:void(0)
'
,
tabindex:
0
,
class:
css_classes
,
data:
{
toggle:
'popover'
,
html:
'true'
,
placement:
'auto top'
,
title:
title
,
content:
content
}
}
=
label
changelogs/unreleased/40198-fix-gpg-badge-links.yml
0 → 100644
View file @
58b05a6e
---
title
:
Fix issue where clicking a GPG verification badge would scroll to the top of
the page
merge_request
:
15407
author
:
type
:
fixed
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment