Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
87d1e865
Commit
87d1e865
authored
Nov 21, 2018
by
Robert Speicher
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Use have_link over have_content for GPG feature
It's more semantically accurate for what we're verifying.
parent
ee172686
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
9 additions
and
9 deletions
+9
-9
spec/features/signed_commits_spec.rb
spec/features/signed_commits_spec.rb
+9
-9
No files found.
spec/features/signed_commits_spec.rb
View file @
87d1e865
...
...
@@ -15,8 +15,8 @@ describe 'GPG signed commits' do
visit
project_commit_path
(
project
,
ref
)
expect
(
page
).
to
have_
content
'Unverified'
expect
(
page
).
not_to
have_
content
'Verified'
expect
(
page
).
to
have_
link
'Unverified'
expect
(
page
).
not_to
have_
link
'Verified'
# user changes his email which makes the gpg key verified
perform_enqueued_jobs
do
...
...
@@ -26,8 +26,8 @@ describe 'GPG signed commits' do
visit
project_commit_path
(
project
,
ref
)
expect
(
page
).
not_to
have_
content
'Unverified'
expect
(
page
).
to
have_
content
'Verified'
expect
(
page
).
not_to
have_
link
'Unverified'
expect
(
page
).
to
have_
link
'Verified'
end
it
'changes from unverified to verified when the user adds the missing gpg key'
do
...
...
@@ -36,8 +36,8 @@ describe 'GPG signed commits' do
visit
project_commit_path
(
project
,
ref
)
expect
(
page
).
to
have_
content
'Unverified'
expect
(
page
).
not_to
have_
content
'Verified'
expect
(
page
).
to
have_
link
'Unverified'
expect
(
page
).
not_to
have_
link
'Verified'
# user adds the gpg key which makes the signature valid
perform_enqueued_jobs
do
...
...
@@ -46,8 +46,8 @@ describe 'GPG signed commits' do
visit
project_commit_path
(
project
,
ref
)
expect
(
page
).
not_to
have_
content
'Unverified'
expect
(
page
).
to
have_
content
'Verified'
expect
(
page
).
not_to
have_
link
'Unverified'
expect
(
page
).
to
have_
link
'Verified'
end
context
'shows popover badges'
,
:js
do
...
...
@@ -136,7 +136,7 @@ describe 'GPG signed commits' do
visit
project_commit_path
(
project
,
GpgHelpers
::
SIGNED_AND_AUTHORED_SHA
)
# wait for the signature to get generated
expect
(
page
).
to
have_
content
'Verified'
expect
(
page
).
to
have_
link
'Verified'
user_1
.
destroy!
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment