Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
8b550db3
Commit
8b550db3
authored
8 years ago
by
Grzegorz Bizon
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add image configuration entry to new ci config
parent
c91298d5
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
68 additions
and
0 deletions
+68
-0
lib/gitlab/ci/config/node/image.rb
lib/gitlab/ci/config/node/image.rb
+22
-0
spec/lib/gitlab/ci/config/node/image_spec.rb
spec/lib/gitlab/ci/config/node/image_spec.rb
+46
-0
No files found.
lib/gitlab/ci/config/node/image.rb
0 → 100644
View file @
8b550db3
module
Gitlab
module
Ci
class
Config
module
Node
##
# Entry that represents a Docker image.
#
class
Image
<
Entry
include
Validatable
validations
do
validates
:config
,
type:
String
end
def
value
@config
end
end
end
end
end
end
This diff is collapsed.
Click to expand it.
spec/lib/gitlab/ci/config/node/image_spec.rb
0 → 100644
View file @
8b550db3
require
'spec_helper'
describe
Gitlab
::
Ci
::
Config
::
Node
::
Image
do
let
(
:entry
)
{
described_class
.
new
(
config
)
}
describe
'validation'
do
context
'when entry config value is correct'
do
let
(
:config
)
{
'ruby:2.2'
}
describe
'#value'
do
it
'returns image string'
do
expect
(
entry
.
value
).
to
eq
'ruby:2.2'
end
end
describe
'#errors'
do
it
'does not append errors'
do
expect
(
entry
.
errors
).
to
be_empty
end
end
describe
'#valid?'
do
it
'is valid'
do
expect
(
entry
).
to
be_valid
end
end
end
context
'when entry value is not correct'
do
let
(
:config
)
{
[
'ruby:2.2'
]
}
describe
'#errors'
do
it
'saves errors'
do
expect
(
entry
.
errors
)
.
to
include
'Image config should be a string'
end
end
describe
'#valid?'
do
it
'is not valid'
do
expect
(
entry
).
not_to
be_valid
end
end
end
end
end
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment