Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
ebf5f31d
Commit
ebf5f31d
authored
6 years ago
by
Clement Ho
Committed by
Mike Greiling
6 years ago
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Set tooltips to have default boundary viewport
parent
1c17aafa
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
8 additions
and
2 deletions
+8
-2
app/assets/javascripts/diff_notes/diff_notes_bundle.js
app/assets/javascripts/diff_notes/diff_notes_bundle.js
+3
-2
app/assets/javascripts/main.js
app/assets/javascripts/main.js
+1
-0
spec/support/features/reportable_note_shared_examples.rb
spec/support/features/reportable_note_shared_examples.rb
+4
-0
No files found.
app/assets/javascripts/diff_notes/diff_notes_bundle.js
View file @
ebf5f31d
...
...
@@ -69,9 +69,10 @@ export default () => {
gl
.
diffNotesCompileComponents
();
if
(
!
hasVueMRDiscussionsCookie
())
{
const
resolveCountAppEl
=
document
.
querySelector
(
'
#resolve-count-app
'
);
if
(
!
hasVueMRDiscussionsCookie
()
&&
resolveCountAppEl
)
{
new
Vue
({
el
:
'
#resolve-count-app
'
,
el
:
resolveCountAppEl
,
components
:
{
'
resolve-count
'
:
ResolveCount
},
...
...
This diff is collapsed.
Click to expand it.
app/assets/javascripts/main.js
View file @
ebf5f31d
...
...
@@ -144,6 +144,7 @@ document.addEventListener('DOMContentLoaded', () => {
$body
.
tooltip
({
selector
:
'
.has-tooltip, [data-toggle="tooltip"]
'
,
trigger
:
'
hover
'
,
boundary
:
'
viewport
'
,
placement
(
tip
,
el
)
{
return
$
(
el
).
data
(
'
placement
'
)
||
'
bottom
'
;
},
...
...
This diff is collapsed.
Click to expand it.
spec/support/features/reportable_note_shared_examples.rb
View file @
ebf5f31d
require
'spec_helper'
shared_examples
'reportable note'
do
|
type
|
include
MobileHelpers
include
NotesHelper
let
(
:comment
)
{
find
(
"#
#{
ActionView
::
RecordIdentifier
.
dom_id
(
note
)
}
"
)
}
...
...
@@ -39,6 +40,9 @@ shared_examples 'reportable note' do |type|
end
def
open_dropdown
(
dropdown
)
# make window wide enough that tooltip doesn't trigger horizontal scrollbar
resize_window
(
1200
,
800
)
dropdown
.
find
(
'.more-actions-toggle'
).
click
dropdown
.
find
(
'.dropdown-menu li'
,
match: :first
)
end
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment