Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
f8e5941d
Commit
f8e5941d
authored
Jul 25, 2017
by
tauriedavis
Committed by
Phil Hughes
Jul 28, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
trying to fix tests
parent
7ea89083
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
14 additions
and
3 deletions
+14
-3
app/views/projects/edit.html.haml
app/views/projects/edit.html.haml
+2
-2
spec/features/projects/settings/merge_requests_settings_spec.rb
...eatures/projects/settings/merge_requests_settings_spec.rb
+12
-1
No files found.
app/views/projects/edit.html.haml
View file @
f8e5941d
...
...
@@ -157,7 +157,7 @@
%p
Customize your merge request restrictions.
.settings-content.no-animate
{
class:
(
'expanded'
if
expanded
)
}
=
form_for
[
@project
.
namespace
.
becomes
(
Namespace
),
@project
],
remote:
true
,
html:
{
multipart:
true
,
class:
"merge-request-settings"
},
authenticity_token:
true
do
|
f
|
=
form_for
[
@project
.
namespace
.
becomes
(
Namespace
),
@project
],
remote:
true
,
html:
{
multipart:
true
,
class:
"merge-request-settings
-form
"
},
authenticity_token:
true
do
|
f
|
=
render
'merge_request_settings'
,
form:
f
=
f
.
submit
'Save changes'
,
class:
"btn btn-save"
...
...
@@ -306,4 +306,4 @@
Saving project.
%p
Please wait a moment, this page will automatically refresh when ready.
=
render
'shared/confirm_modal'
,
phrase:
@project
.
path
\ No newline at end of file
=
render
'shared/confirm_modal'
,
phrase:
@project
.
path
spec/features/projects/settings/merge_requests_settings_spec.rb
View file @
f8e5941d
...
...
@@ -20,6 +20,9 @@ feature 'Project settings > Merge Requests', :js do
expect
(
page
).
to
have_content
(
'Only allow merge requests to be merged if all discussions are resolved'
)
select
'Disabled'
,
from:
"project_project_feature_attributes_merge_requests_access_level"
within
(
'.sharing-permissions-form'
)
do
click_on
(
'Save changes'
)
end
expect
(
page
).
not_to
have_content
(
'Only allow merge requests to be merged if the pipeline succeeds'
)
expect
(
page
).
not_to
have_content
(
'Only allow merge requests to be merged if all discussions are resolved'
)
...
...
@@ -37,6 +40,9 @@ feature 'Project settings > Merge Requests', :js do
expect
(
page
).
to
have_content
(
'Only allow merge requests to be merged if all discussions are resolved'
)
select
'Everyone with access'
,
from:
"project_project_feature_attributes_builds_access_level"
within
(
'.sharing-permissions-form'
)
do
click_on
(
'Save changes'
)
end
expect
(
page
).
to
have_content
(
'Only allow merge requests to be merged if the pipeline succeeds'
)
expect
(
page
).
to
have_content
(
'Only allow merge requests to be merged if all discussions are resolved'
)
...
...
@@ -55,6 +61,9 @@ feature 'Project settings > Merge Requests', :js do
expect
(
page
).
not_to
have_content
(
'Only allow merge requests to be merged if all discussions are resolved'
)
select
'Everyone with access'
,
from:
"project_project_feature_attributes_merge_requests_access_level"
within
(
'.sharing-permissions-form'
)
do
click_on
(
'Save changes'
)
end
expect
(
page
).
to
have_content
(
'Only allow merge requests to be merged if the pipeline succeeds'
)
expect
(
page
).
to
have_content
(
'Only allow merge requests to be merged if all discussions are resolved'
)
...
...
@@ -73,7 +82,9 @@ feature 'Project settings > Merge Requests', :js do
scenario
'when unchecked sets :printing_merge_request_link_enabled to false'
do
uncheck
(
'project_printing_merge_request_link_enabled'
)
click_on
(
'Save'
)
within
(
'.merge-request-settings-form'
)
do
click_on
(
'Save changes'
)
end
# Wait for save to complete and page to reload
checkbox
=
find_field
(
'project_printing_merge_request_link_enabled'
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment