An error occurred fetching the project authors.
  1. 06 Mar, 2018 2 commits
  2. 04 Jan, 2018 1 commit
    • Yorick Peterse's avatar
      Eager load event target authors whenever possible · dac51ace
      Yorick Peterse authored
      This ensures that the "author" association of an event's "target"
      association is eager loaded whenever the "target" association defines an
      "author" association. This in turn solves the N+1 query problem we first
      tried to solve in
      https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/15788 but caused
      problems when displaying milestones as those don't define an "author"
      association.
      
      The approach in this commit does mean that the authors are _always_
      eager loaded since this takes place in the "belongs_to" block. This
      however shouldn't pose too much of a problem, and as far as I can tell
      there's no real way around this unfortunately.
      dac51ace
  3. 22 Dec, 2017 1 commit
  4. 06 Sep, 2017 1 commit
    • Yorick Peterse's avatar
      Finish migration to the new events setup · 235b105c
      Yorick Peterse authored
      This finishes the procedure for migrating events from the old format
      into the new format. Code no longer uses the old setup and the database
      tables used during the migration process are swapped, with the old table
      being dropped.
      
      While the database migration can be reversed this will 1) take a lot of
      time as data has to be coped around 2) won't restore data in the
      "events.data" column as we have no way of restoring this.
      
      Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/37241
      235b105c
  5. 22 Aug, 2017 1 commit
  6. 10 Aug, 2017 1 commit
    • Yorick Peterse's avatar
      Migrate events into a new format · 0395c471
      Yorick Peterse authored
      This commit migrates events data in such a way that push events are
      stored much more efficiently. This is done by creating a shadow table
      called "events_for_migration", and a table called "push_event_payloads"
      which is used for storing push data of push events. The background
      migration in this commit will copy events from the "events" table into
      the "events_for_migration" table, push events in will also have a row
      created in "push_event_payloads".
      
      This approach allows us to reclaim space in the next release by simply
      swapping the "events" and "events_for_migration" tables, then dropping
      the old events (now "events_for_migration") table.
      
      The new table structure is also optimised for storage space, and does
      not include the unused "title" column nor the "data" column (since this
      data is moved to "push_event_payloads").
      
      == Newly Created Events
      
      Newly created events are inserted into both "events" and
      "events_for_migration", both using the exact same primary key value. The
      table "push_event_payloads" in turn has a foreign key to the _shadow_
      table. This removes the need for recreating and validating the foreign
      key after swapping the tables. Since the shadow table also has a foreign
      key to "projects.id" we also don't have to worry about orphaned rows.
      
      This approach however does require some additional storage as we're
      duplicating a portion of the events data for at least 1 release. The
      exact amount is hard to estimate, but for GitLab.com this is expected to
      be between 10 and 20 GB at most. The background migration in this commit
      deliberately does _not_ update the "events" table as doing so would put
      a lot of pressure on PostgreSQL's auto vacuuming system.
      
      == Supporting Both Old And New Events
      
      Application code has also been adjusted to support push events using
      both the old and new data formats. This is done by creating a PushEvent
      class which extends the regular Event class. Using Rails' Single Table
      Inheritance system we can ensure the right class is used for the right
      data, which in this case is based on the value of `events.action`. To
      support displaying old and new data at the same time the PushEvent class
      re-defines a few methods of the Event class, falling back to their
      original implementations for push events in the old format.
      
      Once all existing events have been migrated the various push event
      related methods can be removed from the Event model, and the calls to
      `super` can be removed from the methods in the PushEvent model.
      
      The UI and event atom feed have also been slightly changed to better
      handle this new setup, fortunately only a few changes were necessary to
      make this work.
      
      == API Changes
      
      The API only displays push data of events in the new format. Supporting
      both formats in the API is a bit more difficult compared to the UI.
      Since the old push data was not really well documented (apart from one
      example that used an incorrect "action" nmae) I decided that supporting
      both was not worth the effort, especially since events will be migrated
      in a few days _and_ new events are created in the correct format.
      0395c471
  7. 02 Aug, 2017 1 commit
  8. 27 Jul, 2017 1 commit
  9. 21 Jun, 2017 1 commit
  10. 04 May, 2017 2 commits
  11. 23 Feb, 2017 2 commits
  12. 01 Feb, 2017 1 commit
  13. 26 Jan, 2017 1 commit
  14. 25 Nov, 2016 1 commit
  15. 16 Nov, 2016 1 commit
  16. 09 Nov, 2016 1 commit
  17. 20 Oct, 2016 2 commits
    • Callum Dryden's avatar
      Differentiate the expire from leave event · f488b9f7
      Callum Dryden authored
      At the moment we cannot see weather a user left a project due to their
      membership expiring of if they themselves opted to leave the project.
      This adds a new event type that allows us to make this differentiation.
      Note that is not really feasable to go back and reliably fix up the
      previous events. As a result the events for previous expire removals
      will remain the same however events of this nature going forward will be
      correctly represented.
      f488b9f7
    • Callum Dryden's avatar
      Differentiate the expire from leave event · 9124310f
      Callum Dryden authored
      At the moment we cannot see weather a user left a project due to their
      membership expiring of if they themselves opted to leave the project.
      This adds a new event type that allows us to make this differentiation.
      Note that is not really feasable to go back and reliably fix up the
      previous events. As a result the events for previous expire removals
      will remain the same however events of this nature going forward will be
      correctly represented.
      9124310f
  18. 13 Oct, 2016 1 commit
  19. 11 Oct, 2016 1 commit
  20. 04 Oct, 2016 1 commit
    • Yorick Peterse's avatar
      Remove lease from Event#reset_project_activity · c9bcfc63
      Yorick Peterse authored
      Per GitLab.com's performance metrics this method could take up to 5
      seconds of wall time to complete, while only taking 1-2 milliseconds of
      CPU time. Removing the Redis lease in favour of conditional updates
      allows us to work around this.
      
      A slight drawback is that this allows for multiple threads/processes to
      try and update the same row. However, only a single thread/process will
      ever win since the UPDATE query uses a WHERE condition to only update
      rows that were not updated in the last hour.
      
      Fixes gitlab-org/gitlab-ce#22473
      c9bcfc63
  21. 19 Sep, 2016 1 commit
  22. 07 Jul, 2016 1 commit
  23. 06 Jul, 2016 1 commit
  24. 04 Jul, 2016 1 commit
  25. 16 Jun, 2016 2 commits
  26. 13 Jun, 2016 1 commit
  27. 03 Jun, 2016 2 commits
  28. 09 May, 2016 1 commit
  29. 25 Apr, 2016 1 commit
  30. 24 Mar, 2016 2 commits
  31. 17 Mar, 2016 1 commit
  32. 27 Jan, 2016 1 commit
    • Yorick Peterse's avatar
      Use Atom update times of the first event · de7c9c7a
      Yorick Peterse authored
      By simply loading the first event from the already sorted set we save
      ourselves extra (slow) queries just to get the latest update timestamp.
      This removes the need for Event.latest_update_time and significantly
      reduces the time needed to build an Atom feed.
      
      Fixes gitlab-org/gitlab-ce#12415
      de7c9c7a
  33. 09 Dec, 2015 1 commit