and rubocop fixes

a reconfirmation

for `emails` to be a top level route

This reverts commit 9f186db09d7f380cfbde4c0061be77c272518547.

make sure it stays confirmed

added "Resend confirmation email" for unverified emails

be used with the email profile page as well

an rspec feature

text in the `.text` version consistent with the `.html` version

Send a confirmation email when the user adds a secondary email address. Utilizes the Devise `confirmable` capabilities. Issue #37385

Fix duplicate key errors in PostDeployMigrateUserExternalMailData migration

Closes #38246

See merge request gitlab-org/gitlab-ce!14460

`email_provider` by default is NULL, and if a user had not logged the
value would remain NULL. Upgrading to GitLab 10.0 would lead to a
PG::UniqueViolation because the post-deploy migration would attempt
to reinsert the entry because the NULL comparison between
`users.email_provider` and `user_synced_attributes_metadata.email_provider`
would never match.

Closes #38246

Workaround for n+1 in Projects::TreeController#show

Closes #38171

See merge request gitlab-org/gitlab-ce!14455

Allow the git circuit breaker to correctly handle missing repository storages

Closes #36549

See merge request gitlab-org/gitlab-ce!14417

fix typo in icons section

See merge request gitlab-org/gitlab-ce!14444

Workaround for #38259

See merge request gitlab-org/gitlab-ce!14453

Inform user that current shared projects will remain shared

Closes #38220

See merge request gitlab-org/gitlab-ce!14441

See https://gitlab.com/gitlab-org/gitlab-ce/issues/38261

Removed old icons from project page

Closes #36567

See merge request gitlab-org/gitlab-ce!14185

Don't show %board-add-issues-modal if there's no project

See merge request gitlab-org/gitlab-ce!14442