Signed-off-by: Rémy Coutable <remy@rymai.me>

It was 2*4 => 8 times before, so 4 times is still half retries

In both e2e QA tests and unit tests, reduce the number of retires
to 2 (i.e., 1 initial and one retry)

Add no-op license helper to CE to make it compatible with EE codebase.
Helper will be overwritten in EE to allow for CE specs to be run under
EE codebase.

https://gitlab.com/gitlab-org/gitlab-ee/issues/6539

Signed-off-by: Rémy Coutable <remy@rymai.me>

This brings back some of the changes in
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/20339.

For users using Gitaly on top of NFS, accessing the Git data directly
via Rugged is more performant than Gitaly. This merge request introduces
the feature flag `rugged_find_commit` to activate Rugged paths.

There are also Rake tasks `gitlab:features:enable_rugged` and
`gitlab:features:disable_rugged` to enable/disable these feature
flags altogether.

Part of four Rugged changes identified in
https://gitlab.com/gitlab-org/gitlab-ce/issues/57317.

Signed-off-by: Rémy Coutable <remy@rymai.me>

Signed-off-by: Rémy Coutable <remy@rymai.me>

- we now use the hierarchy class also for epics
- also rename supports_nested_groups? into supports_nested_objects?
  - move it to a concern

migration tests.

We want to run CI with rails 4 for a short-term (until we are sure that
we will ship with rails 5). The problem is that rails 4 can not handle
rails 5 schema.rb properly - specifically `t.index` directive can not
handle multiple indexes on the same column.

Because combination of rails 4 + rails 5 schema will be used
only in CI for a short-term, we can just ignore these incompatibility
failures. This patch adds `rails5` helper for specs.

Signed-off-by: Rémy Coutable <remy@rymai.me>

Move fixture_path out of support/rspec file which is used by fast_spec_helper, so that fast specs can be run on its own again.

Move `fixture_path` config together with use_transactional_fixtures and
use_instantiated_fixtures. These settings are all added by rspec-rails

https://github.com/rspec/rspec-rails/blob/8c6c9590b94916199950dc8a91a9741d3be30c7c/lib/rspec/rails/configuration.rb#L65-L67

We don't test any specific string generated by it yet, so there is no
point in keeping it enabled when we are disabling it everywhere we test its output.

We need this because `expect_any_instance_of` doesn't work on
prepended models. Now we could use the same code between CE/EE

Adding the :prometheus tag to an rspec test will clear out
memory-mapped files and reset the registry.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/39968

Direct disk access is done through Gitaly now, so the legacy path was
deprecated. This path was used in Gitlab::Shell however. This required
the refactoring in this commit.

Added is the removal of direct path access on the project model, as that
lookup wasn't needed anymore is most cases.

Closes https://gitlab.com/gitlab-org/gitaly/issues/1111

Signed-off-by: Rémy Coutable <remy@rymai.me>

Signed-off-by: Rémy Coutable <remy@rymai.me>

Closes gitaly#1110

FactoryBot's build_stubbed ignores the current database sequence of the
projects table and starts at ID 1000. If more than 1000 projects are created
during a test run, leftover repositories can cause spec failures. For example,
a spec that expects an empty repository may fail since there may be existing
content.

Closes #5461

Closes #28857

E.g. https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/52873034