An error occurred fetching the project authors.
  1. 05 Apr, 2017 1 commit
  2. 25 Nov, 2016 3 commits
    • hhoopes's avatar
      Add keyword arguments to truncated_diff method · a761c59a
      hhoopes authored
      * Added keyword arguments to truncated_diff_lines method to allow for using highlighting or not (html templates vs. text)
      * Tweaked templates for consistency and format appropriateness
      a761c59a
    • hhoopes's avatar
      Change diff highlight/truncate for reusability · f928dba9
      hhoopes authored
      Previously the `truncated_diff_lines` method for outputting a discussion diff took in already highlighted lines, which meant it wasn't reuseable for truncating ANY lines. In the way it was used, it also meant that for any email truncation, the whole diff was being highlighted before being truncated, meaning wasted time highlighting lines that wouldn't even be used (granted, they were being memoized, so perhaps this wasn't that great of an issue). I refactored truncation away from highlighting, in order to truncate formatted diffs for text templates in email, using `>`s to designate each line, but otherwise retaining the parsing already done to create `diff_lines`.
      
      Additionally, while notes on merge requests or commits had already been tested, there was no existing test for notes on a diff on an MR or commit. Added mailer tests for such, and a unit test for truncating diff lines.
      f928dba9
    • hhoopes's avatar
      Add new template to handle both commit & mr notes · 24070bac
      hhoopes authored
      Currently comments on commits and merge requests do not require merge request- or commit-specific information, but can use the same template. Rather than change the method which calls the template, I opted to keep the templates separate and create a new template to highlight their identicality, while preserving the option to distinguish them from each other in the future.
      
      Also removed some of the inconsistencies between text and html email versions.
      
      Still needed is a text-only version of git diffs and testing.
      24070bac
  3. 03 Mar, 2014 1 commit
  4. 12 Mar, 2013 1 commit
  5. 10 Aug, 2012 1 commit
  6. 06 Aug, 2012 1 commit
  7. 17 May, 2012 1 commit
  8. 16 May, 2012 1 commit
    • Robb Kidd's avatar
      Make Notify#note_commit_email resque friendly · 0a9a2c2a
      Robb Kidd authored
      Update method to take ids and then perform #finds itself during mailer
      queue worker kick-off. Also, the faux SHA1 cannot have underscores or
      it will not match the commit pattern defined in the routes.
      0a9a2c2a
  9. 23 Apr, 2012 1 commit
  10. 13 Feb, 2012 2 commits
  11. 12 Feb, 2012 1 commit
  12. 15 Oct, 2011 2 commits
  13. 13 Oct, 2011 2 commits
  14. 08 Oct, 2011 1 commit