An error occurred fetching the project authors.
- 02 Aug, 2016 1 commit
-
-
Paco Guzman authored
Speedup DiffNote#active? on discussions, preloading noteables and avoid touching git repository to return diff_refs when possible - Preloading noteable we share the same noteable instance when more than one discussion refers to the same noteable. - Any other call to that object that is cached in that object will be for any discussion. - In those cases where merge_request_diff has all the sha stored to build a diff_refs get that diff_refs using directly those sha instead accessing to the git repository to first get the commits and later the sha.
-
- 31 Jul, 2016 1 commit
-
-
Douglas Barbosa Alexandre authored
When importing a pull request from GitHub, the old and new branches may no longer actually exist by those names, but we need to recreate the merge request diff with the right source and target shas. We use these `target_branch_sha` and `source_branch_sha` attributes to force these to the intended values. But the reader methods were always looking up to the target/source branch head instead of check if these values was previously set.
-
- 08 Jul, 2016 1 commit
-
-
Sean McGivern authored
When rendering a list of diff files, skip those where the diff is over 10 KB and provide an endpoint to render individually instead.
-
- 06 Jul, 2016 2 commits
-
-
Douwe Maan authored
-
Douwe Maan authored
-
- 04 Jul, 2016 1 commit
-
-
Douwe Maan authored
-
- 10 Jun, 2016 4 commits
-
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
The logic of the method was obviously inverted. Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
Based on the feedback from reviewers. Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Rui Anderson authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 03 Jun, 2016 4 commits
-
-
Kamil Trzcinski authored
-
Kamil Trzcinski authored
-
James Lopez authored
This reverts commit 3e991230.
-
James Lopez authored
# Conflicts: # app/models/project.rb
-
- 02 Jun, 2016 2 commits
-
-
Kamil Trzcinski authored
-
Josh Frye authored
-
- 01 Jun, 2016 1 commit
-
-
Yorick Peterse authored
There are several changes to this module: 1. The use of an explicit stack in Participable#participants 2. Proc behaviour has been changed 3. Batch permissions checking == Explicit Stack Participable#participants no longer uses recursion to process "self" and all child objects, instead it uses an Array and processes objects in breadth-first order. This allows us to for example create a single Gitlab::ReferenceExtractor instance and pass this to any Procs. Re-using a ReferenceExtractor removes the need for running potentially many SQL queries every time a Proc is called on a new object. == Proc Behaviour Changed Previously a Proc in Participable was expected to return an Array of User instances. This has been changed and instead it's now expected that a Proc modifies the Gitlab::ReferenceExtractor passed to it. The return value of the Proc is ignored. == Permissions Checking The method Participable#participants uses Ability.users_that_can_read_project to check if the returned users have access to the project of "self" _without_ running multiple SQL queries for every user.
-
- 29 May, 2016 2 commits
-
-
Grzegorz Bizon authored
-
Grzegorz Bizon authored
-
- 20 May, 2016 1 commit
-
-
Jeroen Jacobs authored
-
- 13 May, 2016 1 commit
-
-
Douglas Barbosa Alexandre authored
-
- 09 May, 2016 1 commit
-
-
Jeroen van Baarsen authored
In 8278b763 the default behaviour of annotation has changes, which was causing a lot of noise in diffs. We decided in #17382 that it is better to get rid of the whole annotate gem, and instead let people look at schema.rb for the columns in a table. Fixes: #17382
-
- 11 Apr, 2016 1 commit
-
-
Kamil Trzcinski authored
-
- 29 Mar, 2016 1 commit
-
-
Abhi Rao authored
Fixes #14692
-
- 19 Mar, 2016 1 commit
-
-
Zeger-Jan van de Weg authored
-
- 18 Mar, 2016 2 commits
-
-
Rémy Coutable authored
-
Rémy Coutable authored
We have to ensure source_sha and target_sha are not nil before calling Gitlab::Git::Commit.between.
-
- 17 Mar, 2016 1 commit
-
-
Douglas Barbosa Alexandre authored
-
- 16 Mar, 2016 2 commits
-
-
Pierre de La Morinerie authored
`MergeRequest#source_sha` is expected to return the sha of the source branch last commit. But when a open Merge Request has no diff (e.g. all commits have already been merged to the target branch), `merge_request.source_sha` incorrectly returns `nil`. This was un-noticed before – but now that !2217 has been merged, it makes `Gitlab::Git::Commit.between` raise an "Unexpected nil argument" exception. This fixes the crash, by making sure that `source_sha` returns a correct result even when there is no diff available.
-
Pierre de La Morinerie authored
-
- 11 Mar, 2016 1 commit
-
-
Yorick Peterse authored
The OR condition for source_project_id/target_project_id leads to a query plan that performs rather poorly on PostgreSQL due to the use of sub-queries. Because Rails offers no easy alternative for this particular problem we're forced to using a UNION for both conditions. The resulting query performs much faster than just using an OR.
-
- 03 Mar, 2016 1 commit
-
-
Pierre de La Morinerie authored
-
- 19 Feb, 2016 1 commit
-
-
Rubén Dávila authored
-
- 11 Feb, 2016 1 commit
-
-
Kirill Zaitsev authored
- Add `avatar_url`, `description`, `git_ssh_url`, `git_http_url`, `path_with_namespace` and `default_branch` in `project` in push, issue, merge-request and note webhooks data - Deprecate the `ssh_url` in favor of `git_ssh_url` and `http_url` in favor of `git_http_url` in `project` for push, issue, merge-request and note webhooks data - Deprecate the `repository` key in push, issue, merge-request and note webhooks data, use `project` instead
-
- 04 Feb, 2016 1 commit
-
-
Zeger-Jan van de Weg authored
Fixes #3339 This MR hides the 'Remove source branch' button when a new commit is added to the source branch
-
- 01 Feb, 2016 1 commit
-
-
Yorick Peterse authored
Instead of running ClosingIssueExtractor for every commit in a merge request we can gather all the commit messages (and the merge request description), concatenate all this together and then run ClosingIssueExtractor only once. The result of this is that MergeRequest#closes_issues is now between 3.5x and 4x faster than the old setup. Using a merge request with 10 commits (each referencing a number of issues to close) this reduced the call duration from around 200 milliseconds to around 50 milliseconds. As a result of these changes the Jira related tests for MergeRequest#closes_issues have been removed. These tests stubbed Commit#closes_issues meaning that the only code that was really tested was the call to Array#uniq to filter out duplicate issues. As this code is no longer used (nor present) the corresponding tests were removed. Related: gitlab-org/gitlab-ce#12419
-
- 06 Jan, 2016 2 commits
- 18 Dec, 2015 1 commit
-
-
Drew Blessing authored
-
- 09 Dec, 2015 1 commit
-
-
Douwe Maan authored
-