- 03 Dec, 2019 19 commits
-
-
Jérome Perrin authored
This will allow to find problems when only business templates and their dependencies are installed. When we run testXHTML with all business template installed we don't see problems that may happen only when some business templates are not installed.
-
Jérome Perrin authored
pylint complained about indentation
-
Jérome Perrin authored
this was removed in 2138aee5
-
Jérome Perrin authored
This bt has too many coding style problems for now
-
Jérome Perrin authored
'ticket_view_selection' 'Tickect_viewRelatedRecordList/listbox': set(['erp5_hr_request']) 'Ticket_view/listbox': set(['erp5_crm'])
-
Jérome Perrin authored
'web_page_module_view_web_page_list_selection' 'DocumentModule_viewDocumentListAsJioForOofficeSpreadsheetEditor/listbox': set(['erp5_ooffice_spreadsheet_editor']) 'DocumentModule_viewDocumentListAsJioForOofficePresentationEditor/listbox': set(['erp5_ooffice_presentation_editor']) 'WebPageModule_viewWebPageList/listbox': set(['erp5_web']) 'DocumentModule_viewDocumentListAsJioForOofficeTextEditor/listbox': set(['erp5_ooffice_text_editor']) 'WebPageModule_viewWebTableListAsJioForWebTableEditor/listbox': set(['erp5_web_table_editor'])
-
Jérome Perrin authored
'image_selection' 'ImageModule_viewImageList/listbox': set(['erp5_dms']) 'ImageModule_viewImageListAsJioForImageEditor/listbox': set(['erp5_image_editor']) 'web_page_module_view_web_page_list_selection' 'DocumentModule_viewDocumentListAsJioForOofficeSpreadsheetEditor/listbox': set(['erp5_ooffice_spreadsheet_editor']) 'DocumentModule_viewDocumentListAsJioForOofficePresentationEditor/listbox': set(['erp5_ooffice_presentation_editor']) 'WebPageModule_viewWebPageList/listbox': set(['erp5_web']) 'DocumentModule_viewDocumentListAsJioForOofficeTextEditor/listbox': set(['erp5_ooffice_text_editor']) 'WebPageModule_viewWebTableListAsJioForWebTableEditor/listbox': set(['erp5_web_table_editor'])
-
Jérome Perrin authored
-
Jérome Perrin authored
There are no testVifib (at least not in nexedi/erp5 repository) and there is only one testLive that there is no reason to skip.
-
Jérome Perrin authored
This test never ran because we skip testLive*
-
Jérome Perrin authored
erp5_ingestion contained a skin folder for tests, with some proxy fields depending on erp5_web. There was a proper test dependency to erp5_web, but in static analysis check we now check the skin folders, so it's no longer allowed to have some skin folder that are broken without test dependencies but not supposed to be used outside of tests.
-
Jérome Perrin authored
Since this was using proxy fields from erp5_crm, add dependency on CRM. Update to the new name of CRM field library.
-
Jérome Perrin authored
nuvalidator complains that: Bad value “true” for attribute “autoplay” on element “video” This could probably be switched to VideoField now.
-
Jérome Perrin authored
Unlike other attributes managed in video field, preload [1] is not a boolean attribute, so setting preload="preload" was invalid HTML5. On the field, we can only configure video_preload as a boolean attribute, setting preload="auto" when true and not setting preload when False seems the closest meaning of True/False. [1] https://html.spec.whatwg.org/multipage/media.html#attr-media-preload
-
Jérome Perrin authored
IntegrationSite_view/my_source_payment is a proxyfield to a field in erp5_accounting.
-
Jérome Perrin authored
It uses proxy fields from erp5_crm
-
Jérome Perrin authored
'base_view_document_selection' 'Base_viewDocumentList/listbox': set(['erp5_core']) 'Project_viewDocumentList/listbox': set(['erp5_web_project']) 'project_module_selection' 'ProjectModule_viewProjectList/listbox': set(['erp5_project']) 'ProjectModule_viewProjectManagementList/listbox': set(['erp5_web_project'])
-
Jérome Perrin authored
These selection names were already used in other business templates: 'web_page_module_view_web_page_list_selection' 'WebPageModule_viewWebPageListAsJioForCodemirror/listbox': set(['erp5_officejs_codemirror']) 'WebPageModule_viewWebPageListAsJioForTextEditor/listbox': set(['erp5_text_editor']) 'WebPageModule_viewWebPageList/listbox': set(['erp5_web']) 'DocumentModule_viewDocumentListAsJioForPdfViewer/listbox': set(['erp5_officejs_pdf_viewer']) 'image_selection' 'WebPageModule_viewWebPageListAsJioForSvgEditor/listbox': set(['erp5_officejs_svg_editor']) 'ImageModule_viewImageList/listbox': set(['erp5_dms'])
-
Jérome Perrin authored
Now ERP5JS display list mode header only if the jio key does not contain /, so if we open a module with a hand-made URL with a trailing slash, it's no longer seen as a module. Repair this test by using a URL without that trailing / in the key.
-
- 02 Dec, 2019 10 commits
-
-
Jérome Perrin authored
The counter was not managed properly, it was never increased, so when there was more than one assertion, they were all using the same reference image. Implement also the TODO that prevented to re-run a test.
-
Jérome Perrin authored
This only happens in rare condition: * products where updated and ERP5VCS is moved to portal_components * everything is updated except erp5_forge * preferences for VCS working copies is set
-
Jérome Perrin authored
not sure anybody still use this, but let's repair it.
-
Romain Courteaud authored
Fix an unexpected typo. See nexedi/erp5@71a3f9af
-
Romain Courteaud authored
-
Jérome Perrin authored
* Fix the problem that preference cache was not reset when `setPreferredSomething` was called, only when `edit(preferred_something=)` * Implement something more advanced than just `portal_cache.clearCache()` so that when a user change their preference, only preference of this user are affected. * Increase default cache duration, now that we invalidate caches properly. /reviewed-on !983
-
Jérome Perrin authored
By using a magic comment such as ```javascript // erp5_monaco_editor_include: ../other.js other ``` we can tell monaco editor that other.js will be loaded before the current javascript file, which helps the typescript compiler in diagnosing errors and providing completions. rsvp, renderjs and jio are still always loaded because they are used in almost all our javscripts. /reviewed-on !969
-
Jérome Perrin authored
/reviewed-on !993
-
Jérome Perrin authored
When updating persistent to >= 4.4 `__repr__` of zope objects display information about ZODB connection but it's more useful to have information about the acquisition chain at this level. This happens because `persistent.Persistent.__repr__` is used instead of `OFS.SimpleItem.Item.__repr__` (as of zope 2.13 ). One notable case was proxy field error messages, it was supposed to include the path of the proxy field in the error message. This one is fixed by fixing the MRO so that persistent.Persistent does not appear first. /reviewed-on !991
-
Jérome Perrin authored
testXHTML was testing only document contained in modules, this take another approach to test all portal types and fixes the problems found now that we test views of all portal types. The number of tests in testXHTML also increase from 864 to 1137. /reviewed-on !992
-
- 28 Nov, 2019 11 commits
-
-
Sebastien Robin authored
-
Jérome Perrin authored
-
Jérome Perrin authored
Without this, subclassing defining this method will have arguments-differ pylint warning because the signature of Base._checkConsistency is different.
-
Jérome Perrin authored
These scripts are used to check the site configuration and also in CodingStyleTest. This is just the minimal so that CodingStyleTest can run, but this could be extended to several scripts currently in erp5_toolbox skinfolder of erp5_forge which overlaps with erp5_administration. Also, regarding CodingStyleTest, it seems that erp5_administration contain a lot of things, so we may want to extract a smaller business template containing only the scripts used for static analysis of business template.
-
Jérome Perrin authored
We want this check to run on all components.
-
Jérome Perrin authored
Module is an acceptable prefix for modules Introduce a list of skins IDs that does not match our conventions but are acceptable because this is what external API are calling.
-
Jérome Perrin authored
Some portal types such as Business Template were not tested by testXHTML because this tests started by modules and recursively tests views based on allowed content types. Because of this approach, types that are not created in a module but in a tool were never tested. With unittest, the only way to dynamically add test methods to a class is to generate a test class in test_suite function. At this stage, the ERP5 site is not created yet, so the test had to introspects business templates XML. This now uses a slightly different approach, instead of finding modules and chain of allowed content types from business template XML, we only use business template to introspect the list of actions. The lookup of the appropriate containers is no longer done before setup by static analysis of business templates XML, but later once the site is created, by dynamic analysis of the modules and allowed content types on the running ERP5 site during the test method. If we don't find a chain of portal types, we create the test document in portal_trash, a tool without filter of content types. This way, we can test all views of all portal types. This revealed a few problems: - we need developer role to create components in portal_components, for this we add developer role to the current user. - Delivery Cell portal type looks not used, there are no container accepting it. We don't test delivery cell views for this reason. - VCS view on business template needs preferences and working copy setup. We just mark this test as expected failure for now. - Solver Decision has a form conditionnaly displayed when there's a relation to a solver, but this test does not evaluate action conditions and does not allow to call a script (that would made it possible to modify the document so that the condition is true). For now we also mark this as expected failure.
-
Jérome Perrin authored
Delivery Cell is not really used these days and cannot be created in testXHTML, so drop these useless views. For reference, the same views still exists on all other movements portal types, so we don't "loose anything important" by removing the views here.
-
Jérome Perrin authored
The corresponding form, BudgetTransfer_viewBudgetTransferLine does not exist, so mark view as not visible for now so that it's not tested.
-
Jérome Perrin authored
This redirects to another site, so it is not really a view action. This also confuses testXHTML.
-
Jérome Perrin authored
-