/reviewed-on nexedi/erp5!830

Avoids accumulating useless connections when a single test file contains
multiple files.

Sorting on all documents is a performance killer.

In case no query parameter is available, do not trigger any allDocs
calculation and do not display the listbox, as results would be
meaningless.

For instance, typing a backslash in a relation field does not crash the ui anymore.

/bug #20180123-D78557
https://nexedijs.erp5.net/#/bug_module/20180123-D78557

This property is only conditionally set, which causes distracting error
when something goes wrong. If we really want to check that the expected
code path was followed there has to be a better check and a more debugging-
friendly error than an AttributeError.

While such activity parameter combination does not make sense, it is
technically possible to spawn activities with a group_id set but without a
grouping_method_id.
The consequence is zombie activities: they never fail, do not prevent other
activities from being executed, but and are permanently run on the node
which reserved more than one because:
- all but one activity is in MESSAGE_NOT_EXECUTED state, forcing an abort
- finalizeMessageExecution does not understand that MESSAGE_NOT_EXECUTED
  activities may not have failed, and itself fail while trying to detect
  the failure type (ConflictError vs. others), failing to free & postpone
  the activity, in turn failing to bring it to eventually permanent failure
  state.
Make those conditions consistent, and use tuple-unpacking to detect any
future inconsistency much earlier, simplifying debugging.

group_method_id column is declared "NOT NULL", so it can only be None if
getProcessableMessageList could not find any activity, in which case this
code is not executed ("if message_list" is false).
This simplifies two "if" statements.

So called "click-click" element.

What happens is that in same script (line 907) we want to calculateHateos for
restricted case without passing (I consider explict decision) the response.
What happens is that script will try to redirect to login form using non existing
response parameter. So fix is redirect ONLY if we do pass response.
This allows a Web Site to work with Anonymous accessible content.

@romain  and / or @rporchetto  please feel free to contact me so I show my use case with a real example.

/reviewed-on nexedi/erp5!905

[erp5_trade] Fix Base_viewTradeFieldLibrary/my_view_mode_price to support lines with variations(erp5_advanced_trade).

To use variation is still too complex.

MatrixBox is often used for price tables or code tables. So it is always useful for end users to display its contents.

Make it available for ERP5JS

Store a new Selection everytime a Listbox content is calculated.
This will allow actions checking the selection params to get expected results.

Propagate selection_name in dialog if the dialog doesn't contain a listbox itself.

erp5 jio gadget: follow jio 3.38.1 changes

Ensure that if the web site policy is just set to Must-Revalidate, all documents are updated.
It forces HTTP Cache middleware to refresh their contents.

See nexedi/erp5@f402de4e

Because the number of objects to be retrieved can be too big, or because the query can be complex (depending on the definition of the domain), and because searchAndActivate add a sort on uid (even if it's a primary key, this sort is amplified by the 2 previous reasons), searchAndActivate should be activated to avoid timeouts for the user

erp5_simulation_fast_input: Solve Divergences dialog: Display all divergences in a single ListBox page.

This dialog and its JS gadget does not handle multiple pages ListBox (because
gadget_solve_divergence_dialog.js assumes that the view is the last part of
the URL) and this is not actually needed (customer seldom goes over the
previous limit to 20 anyway).

How to reproduce:
  1. Create >20 divergences (20 lines per page used to be displayed).
  2. Go to Solve Divergences dialog:
     => gadget_solve_divergence_dialog.js:
        -> location.pathname == /erp5/purchase_order_module/42/Delivery_solveDivergenceAction.
           -> basedir=/erp5/purchase_order_module/42.
              => /erp5/purchase_order_module/42/Delivery_getSolveDivergenceDialogParameterFormBox XHR'ed: OK.
  3. Go to any other ListBox page:
     => gadget_solve_divergence_dialog.js:
        -> location.pathname == /erp5/purchase_order_module/42.
           -> basedir=/erp5/purchase_order_module.
              =>/erp5/purchase_order_module/Delivery_getSolveDivergenceDialogParameterFormBox XHR'ed: NOK:
                 [...]
                   Module script, line 4, in Delivery_getSolveDivergenceDialogParameterFormBox
                     - <PythonScript at /erp5/Delivery_getSolveDivergenceDialogParameterFormBox used for /erp5/purchase_order_module>
                     - Line 4
                     solver_process = context.getSolverValueList()[-1]
                 AttributeError: getSolverValueList

erp5_simulation_fast_input: Solve Divergences dialog: Handle error when XHR'ing Solver configuration fails.

When user clicks on the radio button to Accept Decision for example,
Delivery_getSolveDivergenceDialogParameterFormBox is called (XHR) and when it
failed, the 'Solve Divergences' button was disappearing and nothing was
displayed to end-user.

* Not updated for many years (CodeMirror has since replaced it).
* There are now 2 other better source code editors (CodeMirror and Monaco).

Base domain .getRelativeUrl method does not include portal_domains.
See https://lab.nexedi.com/nexedi/erp5/blob/c3f0585cc1ddb888d356b3395b947b90cb188356/product/ERP5/Document/Domain.py#L91

See 88f24700
and 796c3520