1. 12 Jul, 2016 3 commits
    • Jim Fulton's avatar
      Refactored FileStorage transactional undo · 436d6e7b
      Jim Fulton authored
      As part of a project to provide object-level commit locks for ZEO, I'm
      refactiring FileStorage to maintain transaction-specific data in
      Tranaction.data.  This involved undo.  In trying to figure this out, I
      found:
      
      - A bug in _undoDataInfo, which I verified with some tests and
      
      - _transactionalUndoRecord was maddeningly difficult to reason about
        (and thus change).
      
      I was concerned less by the bug than my inability to know whether a
      change to the code would be correct.
      
      So I refactored the code, mainly transactionalUndoRecord, to make the
      code easier to understand, fixing some logic errors (I'm pretty sure)
      along the way.  This included lots of comments. (Comments are much
      easier to compose when you're working out logic you didn't
      understand.)
      
      In addition to makeing the code cleaner, it allows undo to be handled
      in cases that weren't handled before.
      436d6e7b
    • Jim Fulton's avatar
      Merge pull request #87 from NextThought/handle-serials · 686f169f
      Jim Fulton authored
      Per @jimfulton, handle_all_serials shouldn't be sniffing in ZODB5
      
      Thanks.
      686f169f
    • Jason Madden's avatar
  2. 11 Jul, 2016 2 commits
  3. 09 Jul, 2016 2 commits
  4. 06 Jul, 2016 4 commits
  5. 05 Jul, 2016 6 commits
  6. 04 Jul, 2016 12 commits
  7. 01 Jul, 2016 8 commits
    • Jim Fulton's avatar
      5.0.0a3 · a2ae6700
      Jim Fulton authored
      a2ae6700
    • Jim Fulton's avatar
      4.4.1 · 05be22e0
      Jim Fulton authored
      05be22e0
    • Jim Fulton's avatar
      Merge remote-tracking branch 'origin/4' · 76585b67
      Jim Fulton authored
      Conflicts:
      	src/ZODB/interfaces.py
      76585b67
    • Jim Fulton's avatar
      5.0.0a2 · eb04da49
      Jim Fulton authored
      eb04da49
    • Jim Fulton's avatar
      Merge pull request #76 from zopefoundation/IMultiCommitStorage · caf745f6
      Jim Fulton authored
      Define a new interface for storages that support the new commit protocol.
      caf745f6
    • Jim Fulton's avatar
      fixed typos · d74589ef
      Jim Fulton authored
      d74589ef
    • Jim Fulton's avatar
    • Julien Muchembled's avatar
      Better support of the new API to notify of resolved conflicts (store/tpc_finish) · 572a9652
      Julien Muchembled authored
      When switching all storages to the new API in the master branch,
      I found a few issues, mainly with blobs.
      
      1. Created/modified blobs are invalidated during the first phase
         (in Connection._store_objects):
      
          obj._p_invalidate()
      
          And with the old API, _handle_serial then sets _p_serial
          Ghost objects are not supposed to have a _p_serial and with the new API,
          a few tests would fail because _p_serial are checked without activating the
          blob first.
      
      2. Another consequence of _handle_serial not updating _p_changed/_p_serial
         immediately is that created objects are stored twice if __getstate__
         modifies itself. This case is tested in testConnection by
         doctest_lp485456_setattr_in_setstate_doesnt_cause_multiple_stores
      
          Hence the change in Connection._commit:
          - self._modified is already appended in Connection._store_objects
          - (obj._p_serial == z64) instead of (oid in self._creating)
            would not work for savepoints.
      
      3. Setting _p_changed of a Blob with no uncommitted changes would cause an error
         (lp440234_Setting__p_changed_of_a_Blob_w_no_uncomitted_changes_is_noop)
      
          Fixed by the same change as in 2:
          - oid was appended twice to self._modified but reverted one
            (self._modified.pop() in _store_objects)
          - the test passed because _p_changed was reset early by _handle_serial
      572a9652
  8. 30 Jun, 2016 3 commits