1. 12 Apr, 2019 2 commits
  2. 10 Apr, 2019 1 commit
  3. 05 Apr, 2019 1 commit
  4. 04 Apr, 2019 8 commits
  5. 03 Apr, 2019 1 commit
  6. 29 Mar, 2019 1 commit
  7. 28 Mar, 2019 2 commits
  8. 26 Mar, 2019 3 commits
  9. 25 Mar, 2019 2 commits
  10. 22 Mar, 2019 1 commit
  11. 20 Mar, 2019 4 commits
    • Julien Muchembled's avatar
      qa: fix test_getServerAddress (testCMFActivity) · c335c68f
      Julien Muchembled authored
      With recent changes in CMFActivity, getServerAddress is now used
      when setting up the site, before the ZServer is started, which means:
      - getServerAddress memoized a wrong return value;
      - the test didn't fail with --load.
      c335c68f
    • Aurélien Vermylen's avatar
      Clarify "Subscribe/Unsubscribe from Timer Service". · b89e433f
      Aurélien Vermylen authored
      The button "Subscribe/Unsubscribe from Timer Service" does not clearly 
      explain the fact that it determines whether or not Alarms are enabled in
      ERP5. It is very counter-intuitive to see Alarms on "enabled" in the 
      "Configure Alarms" screen and yet not have them being run because the
      Alarm Node is not subscribed to the Timer Service.
      
      /reviewed-on nexedi/erp5!539
      b89e433f
    • Jérome Perrin's avatar
      Fix AccessToken login with ERP5 Login · 601e46e9
      Jérome Perrin authored
      Since the introduction of ERP5 Login, authentication by Access Token is broken, and it is only working if `erp5_login.getReference() == person.getUserId()`
      
      The scriptable part of access token changed, now scripts must return a user object - on which the plugin will call `getUserId` (it was not clear what they should return before, maybe login, but they should return a user id, not a login, as the token plays the same role as a login). To make it clear and to intentionally break compatibility as this is now something different, these scripts have been renamed to be `getUserValue` type based methods.
      
      /reviewed-on !838
      601e46e9
    • Jérome Perrin's avatar
      test: fix python3 syntax errors on testAccounting · d8999426
      Jérome Perrin authored
      (because my editor runs python3 pytlint)
      d8999426
  12. 19 Mar, 2019 9 commits
  13. 14 Mar, 2019 5 commits
    • Xiaowu Zhang's avatar
      erp5_trade: drop caching method for resource list · f1bbc5aa
      Xiaowu Zhang authored
      benefit is very small and unusable for user
      
      nexedi/erp5@1f254aa7
      f1bbc5aa
    • Vincent Pelletier's avatar
      Base._getAcquireLocalRoles: Optimise. · 213974eb
      Vincent Pelletier authored
      This is called when checking access permission on objects, which happens
      very often. CachingMethod has a hit cost which is too high for this use.
      Instead, generate this method as part of the portal type class, removing
      all call-time logic.
      213974eb
    • Vincent Pelletier's avatar
      all: Remove references to im_self. · 6b289998
      Vincent Pelletier authored
      It is superseded by __self__, which (where applicable) prevents
      acquisition and getattr-based traversal, improving performance.
      Patch AccessControl.users.BasicUser._check_context to extend this change
      to zope code (and simplify it in the process).
      Also, make __ac_local_roles__ accesses consistent with other places in
      our own code as well as in PAS & AccessControl.
      6b289998
    • Vincent Pelletier's avatar
      {,Propertied}User: Reduce the overhead from Developer role processing. · 240a8d26
      Vincent Pelletier authored
      getRoles is called a lot (on every restricted access, so hundreds of times
      per transaction), it is definitely not the right place to do extra
      computation, especially when their result does not change from one call
      to the next (configuration should only change on process restart, so not
      during a transaction - and even if it someday did, it should be fine to
      wait for next transaction for it to take effect).
      Instead, do the extra work when creating the user (typically once per
      transaction).
      Also, modernise python syntax (simplifications & style).
      Also, reduce code duplication from ERP5Security.ERP5UserFactory.
      240a8d26
    • Vincent Pelletier's avatar
      DCWorkflowDefinition_listObjectActions: Always return a vector. · e793b164
      Vincent Pelletier authored
      Simplifies callers, as they then do not have to test for None.
      Also, use sort(key=...), which removes the need for internal 2-tuple
      wrapping & unwrapping of all result entries.
      Also, coding style (helps line-based profiling readability) & better
      naming.
      e793b164