co cdh_AttrValueToString() not threadsafe

2adf1b8a · Claes Sjofors · 0aec4e2a · 2adf1b8a
Commit 2adf1b8a authored Jan 26, 2018 by Claes Sjofors
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

src/lib/co/src/co_cdh.c src/lib/co/src/co_cdh.c +2 -1

No files found.
--- a/src/lib/co/src/co_cdh.c
+++ b/src/lib/co/src/co_cdh.c
@@ -550,7 +550,7 @@ cdh_AttrValueToString (
    if (ODD(time_DtoAscii(Value, 1, timbuf, sizeof(timbuf)))) {
      strncpy(String, timbuf, MaxSize);
    } else {
-      snprintf(String, MaxSize, "*** Bad delta time value ***");
+      strncpy(String, "*** Bad delta time value ***", MaxSize);
      sts = CDH__INVDELTATIME;
    }
    break;
@@ -571,6 +571,7 @@ cdh_AttrValueToString (
    break;
  }

+  String[MaxSize-1] = 0;
  return sts;
 }