Speed up getAbsoluteURL

Do not create a DOM document to calculate an URL.

Speed up getAbsoluteURL
Do not create a DOM document to calculate an URL.
e78ac402 · Romain Courteaud · beb63634 · e78ac402 · e78ac402
Commit e78ac402 authored Dec 02, 2016 by Romain Courteaud 🐸
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 15 deletions

Gruntfile.js Gruntfile.js +2 -1

renderjs.js renderjs.js +4 -14

No files found.
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -67,7 +67,8 @@ module.exports = function (grunt) {
            'FileReader',
            'Node',
            'navigator',
-            'Event'
+            'Event',
+            'URL'
          ]
        }
      },

--- a/renderjs.js
+++ b/renderjs.js
@@ -6,7 +6,7 @@
 * http://www.renderjs.org/documentation
 */
 (function (document, window, RSVP, DOMParser, Channel, MutationObserver,
-           Node, FileReader, Blob, navigator, Event) {
+           Node, FileReader, Blob, navigator, Event, URL) {
  "use strict";

  function readBlobAsDataURL(blob) {
@@ -1087,18 +1087,8 @@
  // renderJS.getAbsoluteURL
  /////////////////////////////////////////////////////////////////
  renderJS.getAbsoluteURL = function (url, base_url) {
-    var doc, base, link,
-      html = "<!doctype><html><head></head></html>";
-
-    if (url && base_url && !isAbsoluteOrDataURL.test(url)) {
-      doc = (new DOMParser()).parseFromString(html, 'text/html');
-      base = doc.createElement('base');
-      link = doc.createElement('link');
-      doc.head.appendChild(base);
-      doc.head.appendChild(link);
-      base.href = base_url;
-      link.href = url;
-      return link.href;
+    if (base_url && url) {
+      return new URL(url, base_url).href;
    }
    return url;
  };
@@ -1682,4 +1672,4 @@
  bootstrap();

 }(document, window, RSVP, DOMParser, Channel, MutationObserver, Node,
-  FileReader, Blob, navigator, Event));
+  FileReader, Blob, navigator, Event, URL));