Set symlink permissions properly. (Patch from Andrew Ferguson.)

git-svn-id: http://svn.savannah.nongnu.org/svn/rdiff-backup@758 2b77aa54-bcbc-44c9-a7ec-4f6cf2b41109

branches/r1-0/rdiff-backup/CHANGELOG

 New in v1.0.5 (????/??/??)
 --------------------------
 
+Set symlink permissions properly.  (Patch from Andrew Ferguson.)
+
 Fix a traceback due to an off-by-1 error in "--remove-older-than nB".
 
 Fix a security violation when restoring from a remote repository.

branches/r1-0/rdiff-backup/rdiff_backup/rpath.py

@@ -95,7 +95,12 @@ def copy(rpin, rpout, compress = 0):
 
 	if rpin.isreg(): copy_reg_file(rpin, rpout, compress)
 	elif rpin.isdir(): rpout.mkdir()
-	elif rpin.issym(): rpout.symlink(rpin.readlink())
+	elif rpin.issym():
+		# some systems support permissions for symlinks, but
+		# only by setting at creation via the umask
+		os.umask(0777 - rpin.getperms())
+		rpout.symlink(rpin.readlink())
+		os.umask(077)	# restore rdiff-backup standard umask
 	elif rpin.ischardev():
 		major, minor = rpin.getdevnums()
 		rpout.makedev("c", major, minor)

trunk/rdiff-backup/CHANGELOG

 New in v1.1.6 (????/??/??)
 --------------------------
 
+Set symlink permissions properly.  (Patch from Andrew Ferguson.)
+
 Selection fix: empty directories could sometimes be improperly
 excluded if certain include expressions involving a non-trailing '**'
 were used.  Bug reported by Toni Price.

trunk/rdiff-backup/rdiff_backup/rpath.py

@@ -100,7 +100,12 @@ def copy(rpin, rpout, compress = 0):
 
 	if rpin.isreg(): return copy_reg_file(rpin, rpout, compress)
 	elif rpin.isdir(): rpout.mkdir()
-	elif rpin.issym(): rpout.symlink(rpin.readlink())
+	elif rpin.issym():
+		# some systems support permissions for symlinks, but
+		# only by setting at creation via the umask
+		os.umask(0777 - rpin.getperms())
+		rpout.symlink(rpin.readlink())
+		os.umask(077)	# restore rdiff-backup standard umask
 	elif rpin.ischardev():
 		major, minor = rpin.getdevnums()
 		rpout.makedev("c", major, minor)