Revert dangerous change.

It is better to have few failing tests on check consistency and false positive
alarms then accidentally confirmed Sale Orders.

master/bt5/vifib_erp5/PropertySheetTemplateItem/portal_property_sheets/VifibSaleOrderLineConstraint/line_aggregate_computer_partition_constraint.xml

@@ -86,7 +86,7 @@
         </item>
         <item>
             <key> <string>test_tales_expression</string> </key>
-            <value> <string>python: object.getSimulationState() == \'confirmed\' and object.getResourceValue() is not None and object.getResource() in [object.portal_preferences.getPreferredInstanceSetupResource(), object.portal_preferences.getPreferredInstanceHostingResource(), object.portal_preferences.getPreferredInstanceCleanupResource()]</string> </value>
+            <value> <string>python: object.getResourceValue() is not None and object.getResource() in [object.portal_preferences.getPreferredInstanceSetupResource(), object.portal_preferences.getPreferredInstanceHostingResource(), object.portal_preferences.getPreferredInstanceCleanupResource()]</string> </value>
         </item>
         <item>
             <key> <string>use_acquisition</string> </key>

master/bt5/vifib_erp5/bt/revision

-405
+406
\ No newline at end of file

master/bt5/vifib_slap/SkinTemplateItem/portal_skins/vifib_slap/SaleOrderLine_tryToAllocatePartition.xml

@@ -84,13 +84,11 @@ def assignComputerPartition(order):\n
             software_instance.getPortalType(), software_instance.getSlaXmlAsDict()])\n
           order_line.edit(\n
             aggregate_list=order_line.getAggregateList()+[computer_partition_relative_url])\n
-          return True\n
 \n
 sale_order = context.getParentValue()\n
 if sale_order.getSimulationState() == \'ordered\':\n
-  assigned = False\n
   try:\n
-    assigned = assignComputerPartition(sale_order)\n
+    assignComputerPartition(sale_order)\n
   except ValueError:\n
     # It was not possible to find free Computer Partition\n
     pass\n

master/bt5/vifib_slap/bt/revision

-638
+639
\ No newline at end of file