issues_spec.rb 7.9 KB
Newer Older
gitlabhq's avatar
gitlabhq committed
1 2
require 'spec_helper'

3
describe "Issues", feature: true do
4
  let(:project) { create(:project) }
gitlabhq's avatar
gitlabhq committed
5

Nihad Abbasov's avatar
Nihad Abbasov committed
6
  before do
gitlabhq's avatar
gitlabhq committed
7
    login_as :user
Riyad Preukschas's avatar
Riyad Preukschas committed
8
    user2 = create(:user)
gitlabhq's avatar
fixes  
gitlabhq committed
9

10
    project.team << [[@user, user2], :developer]
gitlabhq's avatar
gitlabhq committed
11 12
  end

13
  describe "Edit issue" do
Riyad Preukschas's avatar
Riyad Preukschas committed
14 15 16 17 18 19 20
    let!(:issue) do
      create(:issue,
             author: @user,
             assignee: @user,
             project: project)
    end

Nihad Abbasov's avatar
Nihad Abbasov committed
21
    before do
gitlabhq's avatar
gitlabhq committed
22 23 24 25
      visit project_issues_path(project)
      click_link "Edit"
    end

Nihad Abbasov's avatar
Nihad Abbasov committed
26
    it "should open new issue popup" do
27
      page.should have_content("Issue ##{issue.iid}")
gitlabhq's avatar
gitlabhq committed
28 29
    end

Nihad Abbasov's avatar
Nihad Abbasov committed
30
    describe "fill in" do
gitlabhq's avatar
gitlabhq committed
31
      before do
32 33
        fill_in "issue_title", with: "bug 345"
        fill_in "issue_description", with: "bug description"
gitlabhq's avatar
gitlabhq committed
34 35
      end

36
      it { expect { click_button "Save changes" }.to_not change {Issue.count} }
gitlabhq's avatar
gitlabhq committed
37

Nihad Abbasov's avatar
Nihad Abbasov committed
38
      it "should update issue fields" do
39
        click_button "Save changes"
gitlabhq's avatar
gitlabhq committed
40 41 42 43 44 45

        page.should have_content @user.name
        page.should have_content "bug 345"
        page.should have_content project.name
      end
    end
46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70

  end

  describe "Editing issue assignee" do
    let!(:issue) do
      create(:issue,
             author: @user,
             assignee: @user,
             project: project)
    end

    it 'allows user to select unasigned', :js => true do
      visit edit_project_issue_path(project, issue)

      page.should have_content "Assign to #{@user.name}"

      page.first('#s2id_issue_assignee_id').click
      sleep 2 # wait for ajax stuff to complete
      page.first('.user-result').click

      click_button "Save changes"

      page.should have_content "Assignee: Select assignee"
      issue.reload.assignee.should be_nil
    end
gitlabhq's avatar
gitlabhq committed
71
  end
Adam Leonard's avatar
Adam Leonard committed
72

73 74 75
  describe "Filter issue" do
    before do
      ['foobar', 'barbaz', 'gitlab'].each do |title|
Riyad Preukschas's avatar
Riyad Preukschas committed
76 77 78 79 80
        create(:issue,
               author: @user,
               assignee: @user,
               project: project,
               title: title)
81 82
      end

83 84 85 86
      @issue = Issue.first # with title 'foobar'
      @issue.milestone = create(:milestone, project: project)
      @issue.assignee = nil
      @issue.save
87 88
    end

89
    let(:issue) { @issue }
Riyad Preukschas's avatar
Riyad Preukschas committed
90

91 92 93 94 95 96 97 98 99
    it "should allow filtering by issues with no specified milestone" do
      visit project_issues_path(project, milestone_id: '0')

      page.should_not have_content 'foobar'
      page.should have_content 'barbaz'
      page.should have_content 'gitlab'
    end

    it "should allow filtering by a specified milestone" do
Riyad Preukschas's avatar
Riyad Preukschas committed
100
      visit project_issues_path(project, milestone_id: issue.milestone.id)
101 102 103 104 105

      page.should have_content 'foobar'
      page.should_not have_content 'barbaz'
      page.should_not have_content 'gitlab'
    end
106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121

    it "should allow filtering by issues with no specified assignee" do
      visit project_issues_path(project, assignee_id: '0')

      page.should have_content 'foobar'
      page.should_not have_content 'barbaz'
      page.should_not have_content 'gitlab'
    end

    it "should allow filtering by a specified assignee" do
      visit project_issues_path(project, assignee_id: @user.id)

      page.should_not have_content 'foobar'
      page.should have_content 'barbaz'
      page.should have_content 'gitlab'
    end
122
  end
123 124 125 126 127 128

  describe 'filter issue' do
    titles = ['foo','bar','baz']
    titles.each_with_index do |title, index|
      let!(title.to_sym) { create(:issue, title: title, project: project, created_at: Time.now - (index * 60)) }
    end
129 130
    let(:newer_due_milestone) { create(:milestone, due_date: '2013-12-11') }
    let(:later_due_milestone) { create(:milestone, due_date: '2013-12-12') }
131 132 133

    it 'sorts by newest' do
      visit project_issues_path(project, sort: 'newest')
134

135 136
      first_issue.should include("foo")
      last_issue.should include("baz")
137 138 139 140 141
    end

    it 'sorts by oldest' do
      visit project_issues_path(project, sort: 'oldest')

142 143
      first_issue.should include("baz")
      last_issue.should include("foo")
144 145 146 147 148 149 150
    end

    it 'sorts by most recently updated' do
      baz.updated_at = Time.now + 100
      baz.save
      visit project_issues_path(project, sort: 'recently_updated')

151
      first_issue.should include("baz")
152 153 154 155 156 157 158
    end

    it 'sorts by least recently updated' do
      baz.updated_at = Time.now - 100
      baz.save
      visit project_issues_path(project, sort: 'last_updated')

159
      first_issue.should include("baz")
160 161 162
    end

    describe 'sorting by milestone' do
163
      before :each do
164 165 166 167 168 169 170 171 172
        foo.milestone = newer_due_milestone
        foo.save
        bar.milestone = later_due_milestone
        bar.save
      end

      it 'sorts by recently due milestone' do
        visit project_issues_path(project, sort: 'milestone_due_soon')

173
        first_issue.should include("foo")
174 175 176 177 178
      end

      it 'sorts by least recently due milestone' do
        visit project_issues_path(project, sort: 'milestone_due_later')

179
        first_issue.should include("bar")
180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195
      end
    end

    describe 'combine filter and sort' do
      let(:user2) { create(:user) }

      before :each do
        foo.assignee = user2
        foo.save
        bar.assignee = user2
        bar.save
      end

      it 'sorts with a filter applied' do
        visit project_issues_path(project, sort: 'oldest', assignee_id: user2.id)

196 197
        first_issue.should include("bar")
        last_issue.should include("foo")
198 199 200 201
        page.should_not have_content 'baz'
      end
    end
  end
202

203 204 205 206 207 208 209 210
  describe 'update assignee from issue#show' do
    let(:issue) { create(:issue, project: project, author: @user) }

    context 'by autorized user' do

      it 'with dropdown menu' do
        visit project_issue_path(project, issue)

Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
211
        find('.edit-issue.inline-update #issue_assignee_id').set project.team.members.first.id
212 213
        click_button 'Update Issue'

Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
214
        page.should have_content "Assignee:"
215 216 217 218 219
        page.has_select?('issue_assignee_id', :selected => project.team.members.first.name)
      end
    end

    context 'by unauthorized user' do
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
220

221
      let(:guest) { create(:user) }
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
222

223 224 225 226 227 228 229 230 231 232 233
      before :each do
        project.team << [[guest], :guest]
        issue.assignee = @user
        issue.save
      end

      it 'shows assignee text' do
        logout
        login_with guest

        visit project_issue_path(project, issue)
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
234
        page.should have_content issue.assignee.name
235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250
      end
    end
  end

  describe 'update milestone from issue#show' do
    let!(:issue) { create(:issue, project: project, author: @user) }
    let!(:milestone) { create(:milestone, project: project) }

    context 'by authorized user' do

      it 'with dropdown menu' do
        visit project_issue_path(project, issue)

        find('.edit-issue.inline-update').select(milestone.title, from: 'issue_milestone_id')
        click_button 'Update Issue'

251
        page.should have_content "Milestone changed to #{milestone.title}"
252 253 254 255 256 257
        page.has_select?('issue_assignee_id', :selected => milestone.title)
      end
    end

    context 'by unauthorized user' do
      let(:guest) { create(:user) }
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
258

259
      before :each do
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
260
        project.team << [guest, :guest]
261 262 263 264 265 266 267 268 269
        issue.milestone = milestone
        issue.save
      end

      it 'shows milestone text' do
        logout
        login_with guest

        visit project_issue_path(project, issue)
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
270
        page.should have_content milestone.title
271 272
      end
    end
273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294

    describe 'removing assignee' do
      let(:user2) { create(:user) }

      before :each do
        issue.assignee = user2
        issue.save
      end

      it 'allows user to remove assignee', :js => true do
        visit project_issue_path(project, issue)
        page.should have_content "Assignee: #{user2.name}"

        page.first('#s2id_issue_assignee_id').click
        sleep 2 # wait for ajax stuff to complete
        page.first('.user-result').click

        page.should have_content "Assignee: Unassigned"
        sleep 2 # wait for ajax stuff to complete
        issue.reload.assignee.should be_nil
      end
    end
295 296
  end

297 298 299 300 301 302 303
  def first_issue
    all("ul.issues-list li").first.text
  end

  def last_issue
    all("ul.issues-list li").last.text
  end
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
304
end