Commits · 122b046b92573f3e1db579b5ff73fa3bdfffc124 · iv / gitlab-ce · GitLab

20 Jul, 2016 28 commits
- Workaround MySQL with INNER JOIN: · 122b046b
  Lin Jen-Shin authored Jul 21, 2016
```
This version of MySQL doesn't yet support 'LIMIT & IN/ALL/ANY/SOME
subquery'

Oh well.
```
  122b046b
- Just put setup directly in the test, feedback: · 8ad92b95
  Lin Jen-Shin authored Jul 21, 2016
```
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13202462
```
  8ad92b95
- Cleanup the use of let, feedback: · ba962aa3
  Lin Jen-Shin authored Jul 21, 2016
```
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13202424
```
  ba962aa3
- Lose unneeded instance variables and variables, feedback: · 01dcb5c2
  Lin Jen-Shin authored Jul 20, 2016
```
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13202326
```
  01dcb5c2
- It's not longer than 80 chars · caf6438a
  Lin Jen-Shin authored Jul 20, 2016
  
  caf6438a
- Make sure there's a build · 08f01dbb
  Lin Jen-Shin authored Jul 20, 2016
  
  08f01dbb
- Use the same logic, it should specify that it's not logged in · eea2fd80
  Lin Jen-Shin authored Jul 20, 2016
  
  eea2fd80
- Use 'when logging as guest' for context, feedback: · a77a58df
  Lin Jen-Shin authored Jul 20, 2016
```
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13200997
```
  a77a58df
- Cleanup that a bit · e8bab842
  Lin Jen-Shin authored Jul 20, 2016
  
  e8bab842
- Rename user2 to reporter_user · 782b384f
  Lin Jen-Shin authored Jul 20, 2016
  
  782b384f
- Should check against `authorize_read_builds!` · ff3776c8
  Lin Jen-Shin authored Jul 20, 2016
  
  ff3776c8
- Reuse those two methods · 88aacaa7
  Lin Jen-Shin authored Jul 20, 2016
  
  88aacaa7
- Also exclude artifacts_file with empty string, feedback: · a7713232
  Lin Jen-Shin authored Jul 20, 2016
```
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13198105
```
  a7713232
- Still give descriptions, feedback: · fea934b5
  Lin Jen-Shin authored Jul 20, 2016
```
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13198953
```
  fea934b5
- Use one query. Feedback: · 4a1edae3
  Lin Jen-Shin authored Jul 20, 2016
```
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13199055
```
  4a1edae3
- It should be plural · fcdfeba9
  Lin Jen-Shin authored Jul 20, 2016
  
  fcdfeba9
- Avoid mixing builds from different pipelines: · 9f70abf1
  Lin Jen-Shin authored Jul 20, 2016
```
So we no longer join anything, just find the latest pipeline
and load builds from there to avoid mixing builds.

Thanks Kamil for the help and tests.
```
  9f70abf1
- Cleanup let a bit, feedback: · a9f3f3c8
  Lin Jen-Shin authored Jul 20, 2016
```
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13195683
and
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13195692

another_artifacts was no longer used and then there's no point to
put let in outer scope anymore.
```
  a9f3f3c8
- Use only one before, feedback: · 145da6b1
  Lin Jen-Shin authored Jul 20, 2016
```
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13195672
```
  145da6b1
- Past tense: · 0c202f37
  Lin Jen-Shin authored Jul 20, 2016
```
Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13195632
```
  0c202f37
- Past tense, feedback: · bdb900cd
  Lin Jen-Shin authored Jul 20, 2016
```
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13195632
```
  bdb900cd
- Join on association · a563f331
  Lin Jen-Shin authored Jul 20, 2016
  
  a563f331
- More complex data manipulating tests to model, and · 66c8c3d4
  Lin Jen-Shin authored Jul 20, 2016
```
this should properly test that it's really getting the
builds from the latest successful pipelines and latest
successful builds.
```
  66c8c3d4
- We need INNER JOIN to get the right pipeline, · 2fe8ebc1
  Lin Jen-Shin authored Jul 20, 2016
```
also added a test for checking this.
```
  2fe8ebc1
- Use shared_examples, feedback: · 3925436a
  Lin Jen-Shin authored Jul 20, 2016
```
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13173599
```
  3925436a
- Use shared_example rather than methods, feedback: · cf78c357
  Lin Jen-Shin authored Jul 20, 2016
```
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13173653
```
  cf78c357
- That means different things but it's ok here. · 709e805d
  Lin Jen-Shin authored Jul 20, 2016
```
rubocop was complaining
```
  709e805d
- Create the pipelines/builds in mixed order, feedback: · b0f7384f
  Lin Jen-Shin authored Jul 20, 2016
```
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13176921

Also we give undesired builds another artifacts so that we could tell
if returned artifacts was we actual expected.
```
  b0f7384f
19 Jul, 2016 12 commits
- It's no longer needed · 02f58dbd
  Lin Jen-Shin authored Jul 20, 2016
  
  02f58dbd
- Merge remote-tracking branch... · 9ab5ff53
  Lin Jen-Shin authored Jul 20, 2016
```
Merge remote-tracking branch 'upstream/artifacts-from-ref-and-build-name-api-kamil' into artifacts-from-ref-and-build-name-api

* upstream/artifacts-from-ref-and-build-name-api-kamil:
  Make minimal changes to specs
```
  9ab5ff53
- Make minimal changes to specs · 719b0f11
  Kamil Trzcinski authored Jul 19, 2016
  
  719b0f11
- Move Project#latest_successful_builds_for to project_spec.rb · cfd7c445
  Lin Jen-Shin authored Jul 20, 2016
```
Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13173313
```
  cfd7c445
- Just use default_branch, feedback: · dc6afd57
  Lin Jen-Shin authored Jul 20, 2016
```
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13176885
```
  dc6afd57
- Now we could use normal relation, feedback: · 09114211
  Lin Jen-Shin authored Jul 20, 2016
```
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13173842
```
  09114211
- Use default_branch rather than master, feedback: · 04658761
  Lin Jen-Shin authored Jul 20, 2016
```
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13173871
```
  04658761
- path_from_ref -> path_for_ref, feedback: · ae83ac99
  Lin Jen-Shin authored Jul 20, 2016
```
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347/diffs#note_13173404
```
  ae83ac99
- Drop description for simple case, feedback: · 6da27aa6
  Lin Jen-Shin authored Jul 20, 2016
```
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347/diffs#note_13173445
```
  6da27aa6
- when unauthorized, feedback: · 361f3d06
  Lin Jen-Shin authored Jul 20, 2016
```
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347/diffs#note_13173429
```
  361f3d06
- Check against type explicit, feedback: · 43b6a3ea
  Lin Jen-Shin authored Jul 20, 2016
```
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347/diffs#note_13173368
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347/diffs#note_13173370
```
  43b6a3ea
- Use for, feedback: · 42656104
  Lin Jen-Shin authored Jul 20, 2016
```
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347/diffs#note_13173345
```
  42656104