Add specs for generated artifacts metadata paths

internal/zipartifacts/metadata.go

@@ -77,8 +77,8 @@ func generateZipMetadata(output io.Writer, archive *zip.Reader) error {
 	for _, entry := range archive.File {
 		zipMap[entry.Name] = entry
 
-		for entryPath := path.Dir(entry.Name); entryPath != "." && entryPath != "/"; entryPath = path.Dir(entryPath) {
-			entryDir := entryPath + "/"
+		for d := path.Dir(entry.Name); d != "." && d != "/"; d = path.Dir(d) {
+			entryDir := d + "/"
 			if _, ok := zipMap[entryDir]; !ok {
 				zipMap[entryDir] = nil
 			}

internal/zipartifacts/metadata_test.go

+package zipartifacts
+
+import (
+	"archive/zip"
+	"bytes"
+	"encoding/binary"
+	"fmt"
+	"testing"
+)
+
+func TestMissingMetadataEntries(t *testing.T) {
+	var zipBuffer, metaBuffer bytes.Buffer
+
+	archive := zip.NewWriter(&zipBuffer)
+
+	firstFile, err := archive.Create("file1")
+	if err != nil {
+		t.Fatal(err)
+	}
+	fmt.Fprint(firstFile, "test12")
+
+	secondFile, err := archive.Create("some/file/dir/file2")
+	if err != nil {
+		t.Fatal(err)
+	}
+	fmt.Fprint(secondFile, "test125678")
+
+	archive.Close()
+
+	zipReader := bytes.NewReader(zipBuffer.Bytes())
+	zipArchiveReader, _ := zip.NewReader(zipReader, int64(binary.Size(zipBuffer.Bytes())))
+	err = generateZipMetadata(&metaBuffer, zipArchiveReader)
+
+	paths := []string{"file1", "some/", "some/file/", "some/file/dir", "some/file/dir/file2"}
+	for _, path := range paths {
+		if !bytes.Contains(metaBuffer.Bytes(), []byte(path)) {
+			t.Fatalf("zipartifacts: metadata for path %s not found!", path)
+		}
+	}
+}