1. 25 Feb, 2024 10 commits
    • Jérome Perrin's avatar
      Revert "fixup! test: enable activity tracking in debug mode." NOT FOR MERGE · 8bf0bae4
      Jérome Perrin authored
      This reverts commit f384b68f.
      
      activity tracking impacts performance too much
      8bf0bae4
    • Jérome Perrin's avatar
      base: sort matrix in Currency Exchange Line · 9c5a7ed3
      Jérome Perrin authored
      Revealed by erp5_accounting_ui_test:testERP5CurrencyExchangeLine
      PYTHONHASHSEED: 438 on py2
      9c5a7ed3
    • Jérome Perrin's avatar
      web_renderjs_ui_test: don't depend on dict iteration order · be4fa02e
      Jérome Perrin authored
      revealed by erp5_web_renderjs_ui_test:testFunctionalRJSDeveloperMode
      with PYTHONHASHSEED: 977 on py2
      be4fa02e
    • Jérome Perrin's avatar
      SQLCatalog: keep the order when building query from AST · 65a99e2d
      Jérome Perrin authored
      When searching for something like for example "A AND B", make sure that
      the AND complex query contains query for ["A", "B"], not ["B", "A"].
      This is probably always equivalent in generated SQL, but this makes
      testing easier.
      
      Revealed by testSQLCatalog.TestSQLCatalog with PYTHONHASHSEED 279 on py2
      65a99e2d
    • Jérome Perrin's avatar
      syncml: use cutXML with str, not bytes · e503e504
      Jérome Perrin authored
      When cutting with bytes, we might cut in the middle of a multi-bytes
      character and later decoding it would cause an error. We could switch
      to sending bytes encoded to base64, because the limit would be more
      natural to be number of bytes, but just decoding and cutting the string
      is easier and in practice not so different.
      
      This bug was revealed by testERP5SyncML.TestERP5SyncML.test_28_PartialData
      with PYTHONHASHSEED 872 on python2
      e503e504
    • Jérome Perrin's avatar
      Base_asXML: sort properties in asXML · e1f7c242
      Jérome Perrin authored
      The order is used during syncml and if "title" comes before "first_name"
      and "last_name", synchronizing persons causes conflicts (because title
      of persons is computed from first_name and last_name).
      Luckily, sorting properties gives an order that is OK for syncml tests,
      so we don't need to invent a new mechanism to control the order of
      properties in asXML.
      e1f7c242
    • Jérome Perrin's avatar
      TextDocument: don't change xml documents content type · 3653dfb5
      Jérome Perrin authored
      if their content type ended in xml ( such as image/svg+xml ),
      TextDocument._convertToBaseFormat was resetting the content type to
      application/xml.
      
      When doing something like:
      
        wp = web_page_module.newContent(
          portal_type='Web Page',
          content_type='image/svg+xml',
          text_content=svg
        )
      
      wp.getContentType() was sometimes 'image/svg+xml' sometimes
      'application/xml', depending on the order of edit.
      3653dfb5
    • Jérome Perrin's avatar
      0ed42f1c
    • Jérome Perrin's avatar
      *: refactor edit_order of Base._edit 💥 · 6dbd6f76
      Jérome Perrin authored
      and maybe :
      
      ERP5Type/Base: execute workflow interactions in alphabetic order
      
      With a perfect configuration, this should probably does not matter,
      because the order of interactions should not be important (if there
      are dependencies they should be handled more explicitly), but this
      makes the behavior deterministic.
      
      and maybe:
      
      always sort in edit
      6dbd6f76
    • Jérome Perrin's avatar
      base: fix movement_resource_interaction_workflow · bf46978e
      Jérome Perrin authored
      movement.hasCategory('quantity_unit') was always false, it was a
      misunderstanding of hasCategory API. This was working anyway because
      of the order of edit (which depends on iteration order of **kw arguments
      passed to edit), this was only working when quantity unit was set before
      resource.
      
      ( this was revealed by test_01_quantity_unit_copied from testInvoice
      running on python2 with PYTHONHASHSEED=164 )
      bf46978e
  2. 23 Feb, 2024 2 commits
  3. 22 Feb, 2024 8 commits
  4. 21 Feb, 2024 4 commits
  5. 16 Feb, 2024 1 commit
  6. 15 Feb, 2024 1 commit
  7. 13 Feb, 2024 1 commit
  8. 12 Feb, 2024 1 commit
    • Vincent Pelletier's avatar
      Base_getWorkflowHistoryItemList: Remove access override · 1532fabb
      Vincent Pelletier authored
      This script has no reason to be an exception to user's title retrieval
      permissions.
      Non-ERP5 users do not have applicable access control, so handle those
      cases specifically. Such users may be:
      - since-deleted ERP5 users
      - coming from acl_users/zodb_users
      Use a generic placeholder when the user is not allowed to see a
      transition's actor.
      1532fabb
  9. 09 Feb, 2024 7 commits
  10. 08 Feb, 2024 3 commits
  11. 07 Feb, 2024 1 commit
  12. 06 Feb, 2024 1 commit