Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Jérome Perrin
gitlab-ce
Commits
3073f1aa
Commit
3073f1aa
authored
Feb 26, 2018
by
Dmitriy Zaporozhets
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Handle excpetion in PluginWorker
Signed-off-by:
Dmitriy Zaporozhets
<
dmitriy.zaporozhets@gmail.com
>
parent
4b998239
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
29 additions
and
0 deletions
+29
-0
app/workers/plugin_worker.rb
app/workers/plugin_worker.rb
+2
-0
spec/workers/plugin_worker_spec.rb
spec/workers/plugin_worker_spec.rb
+27
-0
No files found.
app/workers/plugin_worker.rb
View file @
3073f1aa
...
...
@@ -5,5 +5,7 @@ class PluginWorker
def
perform
(
file_name
,
data
)
Gitlab
::
Plugin
.
execute
(
file_name
,
data
)
rescue
=>
e
Rails
.
logger
.
error
(
"
#{
self
.
class
}
:
#{
e
.
message
}
"
)
end
end
spec/workers/plugin_worker_spec.rb
0 → 100644
View file @
3073f1aa
require
'spec_helper'
describe
PluginWorker
do
include
RepoHelpers
subject
{
described_class
.
new
}
let
(
:filename
)
{
'my_plugin.rb'
}
describe
'#perform'
do
it
'executes Gitlab::Plugin with expected values'
do
data
=
{
'event_name'
=>
'project_create'
}
allow
(
Gitlab
::
Plugin
).
to
receive
(
:execute
).
with
(
filename
,
data
).
and_return
(
true
)
expect
(
subject
.
perform
(
filename
,
data
)).
to
be_truthy
end
it
'handles exception well'
do
data
=
{
'event_name'
=>
'project_create'
}
allow
(
Gitlab
::
Plugin
).
to
receive
(
:execute
).
with
(
filename
,
data
).
and_raise
(
'Permission denied'
)
expect
{
subject
.
perform
(
filename
,
data
)
}.
to_not
raise_error
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment