Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Jérome Perrin
gitlab-ce
Commits
77c254f2
Commit
77c254f2
authored
Dec 08, 2017
by
Annabel Dunstone Gray
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Rename page-with-sidebar to layout-page
parent
b592005f
Changes
8
Hide whitespace changes
Inline
Side-by-side
Showing
8 changed files
with
13 additions
and
13 deletions
+13
-13
app/assets/javascripts/contextual_sidebar.js
app/assets/javascripts/contextual_sidebar.js
+1
-1
app/assets/javascripts/issuable_bulk_update_sidebar.js
app/assets/javascripts/issuable_bulk_update_sidebar.js
+1
-1
app/assets/javascripts/main.js
app/assets/javascripts/main.js
+2
-2
app/assets/javascripts/right_sidebar.js
app/assets/javascripts/right_sidebar.js
+4
-4
app/assets/stylesheets/framework/layout.scss
app/assets/stylesheets/framework/layout.scss
+2
-2
app/assets/stylesheets/pages/boards.scss
app/assets/stylesheets/pages/boards.scss
+1
-1
app/views/layouts/_page.html.haml
app/views/layouts/_page.html.haml
+1
-1
spec/javascripts/right_sidebar_spec.js
spec/javascripts/right_sidebar_spec.js
+1
-1
No files found.
app/assets/javascripts/contextual_sidebar.js
View file @
77c254f2
...
...
@@ -9,7 +9,7 @@ export default class ContextualSidebar {
}
initDomElements
()
{
this
.
$page
=
$
(
'
.
page-with-sidebar
'
);
this
.
$page
=
$
(
'
.
layout-page
'
);
this
.
$sidebar
=
$
(
'
.nav-sidebar
'
);
this
.
$innerScroll
=
$
(
'
.nav-sidebar-inner-scroll
'
,
this
.
$sidebar
);
this
.
$overlay
=
$
(
'
.mobile-overlay
'
);
...
...
app/assets/javascripts/issuable_bulk_update_sidebar.js
View file @
77c254f2
...
...
@@ -21,7 +21,7 @@ export default class IssuableBulkUpdateSidebar {
}
initDomElements
()
{
this
.
$page
=
$
(
'
.
page-with-sidebar
'
);
this
.
$page
=
$
(
'
.
layout-page
'
);
this
.
$sidebar
=
$
(
'
.right-sidebar
'
);
this
.
$sidebarInnerContainer
=
this
.
$sidebar
.
find
(
'
.issuable-sidebar
'
);
this
.
$bulkEditCancelBtn
=
$
(
'
.js-bulk-update-menu-hide
'
);
...
...
app/assets/javascripts/main.js
View file @
77c254f2
...
...
@@ -128,7 +128,7 @@ $(function () {
});
if
(
bootstrapBreakpoint
===
'
xs
'
)
{
const
$rightSidebar
=
$
(
'
aside.right-sidebar, .
page-with-sidebar
'
);
const
$rightSidebar
=
$
(
'
aside.right-sidebar, .
layout-page
'
);
$rightSidebar
.
removeClass
(
'
right-sidebar-expanded
'
)
...
...
@@ -188,7 +188,7 @@ $(function () {
trigger
:
'
focus
'
,
// set the viewport to the main content, excluding the navigation bar, so
// the navigation can't overlap the popover
viewport
:
'
.
page-with-sidebar
'
viewport
:
'
.
layout-page
'
});
$
(
'
.trigger-submit
'
).
on
(
'
change
'
,
function
()
{
return
$
(
this
).
parents
(
'
form
'
).
submit
();
...
...
app/assets/javascripts/right_sidebar.js
View file @
77c254f2
...
...
@@ -42,11 +42,11 @@ import Cookies from 'js-cookie';
if
(
$thisIcon
.
hasClass
(
'
fa-angle-double-right
'
))
{
$allGutterToggleIcons
.
removeClass
(
'
fa-angle-double-right
'
).
addClass
(
'
fa-angle-double-left
'
);
$
(
'
aside.right-sidebar
'
).
removeClass
(
'
right-sidebar-expanded
'
).
addClass
(
'
right-sidebar-collapsed
'
);
$
(
'
.
page-with-sidebar
'
).
removeClass
(
'
right-sidebar-expanded
'
).
addClass
(
'
right-sidebar-collapsed
'
);
$
(
'
.
layout-page
'
).
removeClass
(
'
right-sidebar-expanded
'
).
addClass
(
'
right-sidebar-collapsed
'
);
}
else
{
$allGutterToggleIcons
.
removeClass
(
'
fa-angle-double-left
'
).
addClass
(
'
fa-angle-double-right
'
);
$
(
'
aside.right-sidebar
'
).
removeClass
(
'
right-sidebar-collapsed
'
).
addClass
(
'
right-sidebar-expanded
'
);
$
(
'
.
page-with-sidebar
'
).
removeClass
(
'
right-sidebar-collapsed
'
).
addClass
(
'
right-sidebar-expanded
'
);
$
(
'
.
layout-page
'
).
removeClass
(
'
right-sidebar-collapsed
'
).
addClass
(
'
right-sidebar-expanded
'
);
if
(
gl
.
lazyLoader
)
gl
.
lazyLoader
.
loadCheck
();
}
...
...
@@ -173,7 +173,7 @@ import Cookies from 'js-cookie';
Sidebar
.
prototype
.
setCollapseAfterUpdate
=
function
(
$block
)
{
$block
.
addClass
(
'
collapse-after-update
'
);
return
$
(
'
.
page-with-sidebar
'
).
addClass
(
'
with-overlay
'
);
return
$
(
'
.
layout-page
'
).
addClass
(
'
with-overlay
'
);
};
Sidebar
.
prototype
.
onSidebarDropdownHidden
=
function
(
e
)
{
...
...
@@ -187,7 +187,7 @@ import Cookies from 'js-cookie';
Sidebar
.
prototype
.
sidebarDropdownHidden
=
function
(
$block
)
{
if
(
$block
.
hasClass
(
'
collapse-after-update
'
))
{
$block
.
removeClass
(
'
collapse-after-update
'
);
$
(
'
.
page-with-sidebar
'
).
removeClass
(
'
with-overlay
'
);
$
(
'
.
layout-page
'
).
removeClass
(
'
with-overlay
'
);
return
this
.
toggleSidebar
(
'
hide
'
);
}
};
...
...
app/assets/stylesheets/framework/layout.scss
View file @
77c254f2
...
...
@@ -106,11 +106,11 @@ body {
}
}
.
page-with-sidebar
>
.content-wrapper
{
.
layout-page
>
.content-wrapper
{
min-height
:
calc
(
100vh
-
#{
$header-height
}
);
}
.with-performance-bar
.
page-with-sidebar
{
.with-performance-bar
.
layout-page
{
margin-top
:
$header-height
+
$performance-bar-height
;
}
...
...
app/assets/stylesheets/pages/boards.scss
View file @
77c254f2
...
...
@@ -415,7 +415,7 @@
margin
:
5px
;
}
.page-with-contextual-sidebar.
page-with-sidebar
.issue-boards-sidebar
{
.page-with-contextual-sidebar.
layout-page
.issue-boards-sidebar
{
.issuable-sidebar-header
{
position
:
relative
;
}
...
...
app/views/layouts/_page.html.haml
View file @
77c254f2
.
page-with-sidebar
{
class:
page_with_sidebar_class
}
.
layout-page
{
class:
page_with_sidebar_class
}
-
if
defined?
(
nav
)
&&
nav
=
render
"layouts/nav/sidebar/
#{
nav
}
"
.content-wrapper
...
...
spec/javascripts/right_sidebar_spec.js
View file @
77c254f2
...
...
@@ -41,7 +41,7 @@ import '~/right_sidebar';
loadFixtures
(
fixtureName
);
this
.
sidebar
=
new
Sidebar
;
$aside
=
$
(
'
.right-sidebar
'
);
$page
=
$
(
'
.
page-with-sidebar
'
);
$page
=
$
(
'
.
layout-page
'
);
$icon
=
$aside
.
find
(
'
i
'
);
$toggle
=
$aside
.
find
(
'
.js-sidebar-toggle
'
);
return
$labelsIcon
=
$aside
.
find
(
'
.sidebar-collapsed-icon
'
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment