An error occurred fetching the project authors.
  1. 06 Mar, 2018 1 commit
  2. 07 Feb, 2018 1 commit
  3. 09 Jan, 2018 1 commit
    • Zeger-Jan van de Weg's avatar
      Migrate GitlabProject (re)move project endpoints · 58e17bf3
      Zeger-Jan van de Weg authored
      Migration is done through a small refactoring, which makes us call
      endpoins which are performing the same actions for namespaces.
      Tests are added to ensure only the project is removed that should be
      removed.
      
      Closes gitlab-org/gitaly#873
      58e17bf3
  4. 08 Jan, 2018 4 commits
    • James Edwards-Jones's avatar
      Fix spec in shell_spec.rb · bd9ead68
      James Edwards-Jones authored
      The spec for "#add_key does nothing" would always have passed,
      since the expectation was on both the wrong object and message.
      bd9ead68
    • Valery Sizov's avatar
      d9557e43
    • Michael Kozono's avatar
      Backport authorized_keys_enabled defaults to true' · 797fe0a6
      Michael Kozono authored
      Originally from branch 'fix-authorized-keys-enabled-default-2738' via merge request https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2240
      
      Removed background migrations which were intended to fix state after using Gitlab
      without a default having been set
      
      Squashed commits:
      Locally, if Spring was not restarted, `current_application_settings` was still cached, which prevented the migration from editing the file. This will also ensure that any app server somehow hitting old cache data will properly default this setting regardless.
      Retroactively fix migration
        This allows us to identify customers who ran the broken migration. Their `authorized_keys_enabled` column does not have a default at this point.
        We will fix the column after we fix the `authorized_keys` file.
      Fix authorized_keys file if needed
      Add default to authorized_keys_enabled setting
        Reminder: The original migration was fixed retroactively a few commits ago, so people who did not ever run GitLab 9.3.0 already have a column that defaults to true and disallows nulls. I have tested on PostgreSQL and MySQL that it is safe to run this migration regardless.
        Affected customers who did run 9.3.0 are the ones who need this migration to fix the authorized_keys_enabled column.
        The reason for the retroactive fix plus this migration is that it allows us to run a migration in between to fix the authorized_keys file only for those who ran 9.3.0.
      Tweaks to address feedback
      Extract work into background migration
      Move batch-add-logic to background migration
        Do the work synchronously to avoid multiple workers attempting to add batches of keys at the same time.
        Also, make the delete portion wait until after adding is done.
      Do read and delete work in background migration
      Fix Rubocop offenses
      Add changelog entry
      Inform the user of actions taken or not taken
      Prevent unnecessary `select`s and `remove_key`s
      Add logs for action taken
      Fix optimization
      Reuse `Gitlab::ShellAdapter`
      Guarantee the earliest key
      Fix migration spec for MySQL
      797fe0a6
    • Michael Kozono's avatar
      Backport option to disable writing to `authorized_keys` file · 255a0f85
      Michael Kozono authored
      Originally branch 'mk-toggle-writing-to-auth-keys-1631'
      
      See merge request !2004
      
      Squashed commits:
      Add authorized_keys_enabled to Application Settings
      Ensure default settings are exposed in UI
      Without this change, `authorized_keys_enabled` is unchecked when it is nil, even if it should be checked by default.
      Add “Speed up SSH operations” documentation
      Clarify the reasons for disabling writes
      Add "How to go back" section
      Tweak copy
      Update Application Setting screenshot
      255a0f85
  5. 05 Jan, 2018 1 commit
  6. 04 Jan, 2018 2 commits
  7. 14 Dec, 2017 1 commit
    • Nick Thomas's avatar
      Import gitlab_projects.rb from gitlab-shell · 4b785df2
      Nick Thomas authored
      By importing this Ruby code into gitlab-rails (and gitaly-ruby), we avoid
      200ms of startup time for each gitlab_projects subprocess we are eliminating.
      
      By not having a gitlab_projects subprocess between gitlab-rails / sidekiq and
      any git subprocesses (e.g. for fork_project, fetch_remote, etc, calls), we can
      also manage these git processes more cleanly, and avoid sending SIGKILL to them
      4b785df2
  8. 04 Dec, 2017 1 commit
  9. 07 Oct, 2017 1 commit
    • Jacopo's avatar
      Replaces `tag: true` into `:tag` in the specs · 0ce67858
      Jacopo authored
      Replaces all the explicit include metadata syntax in the specs (tag:
      true) into the implicit one (:tag).
      Added a cop to prevent future errors and handle autocorrection.
      0ce67858
  10. 05 Oct, 2017 1 commit
  11. 02 Oct, 2017 1 commit
  12. 29 Sep, 2017 1 commit
  13. 28 Sep, 2017 1 commit
  14. 30 Aug, 2017 1 commit
  15. 15 Aug, 2017 1 commit
  16. 07 Aug, 2017 1 commit
  17. 27 Jul, 2017 2 commits
  18. 03 Jul, 2017 1 commit
  19. 26 Apr, 2017 1 commit
  20. 05 Apr, 2017 1 commit
    • Stan Hu's avatar
      Handle SSH keys that have multiple spaces between each marker · 54849afc
      Stan Hu authored
      Notice what happens when a user adds a key with a space in between:
      
      ```
      irb(main):004:0> 'ssh-rsa  foobar'.split(/ /)
      => ["ssh-rsa", "", "foobar"]
      ```
      
      This would cause gitlab-shell to receive a blank argument for the actual
      key, leading to users unable to login.
      54849afc
  21. 04 Nov, 2016 1 commit
  22. 07 Oct, 2016 1 commit
  23. 06 Oct, 2016 1 commit
  24. 16 Sep, 2016 1 commit
  25. 30 Jun, 2016 2 commits
  26. 09 Dec, 2015 1 commit
  27. 09 Oct, 2015 1 commit
  28. 22 Jun, 2015 1 commit
  29. 12 Feb, 2015 1 commit
  30. 15 Apr, 2013 1 commit
  31. 03 Apr, 2013 1 commit
  32. 11 Feb, 2013 1 commit
  33. 05 Feb, 2013 2 commits