An error occurred fetching the project authors.
- 14 Mar, 2018 1 commit
-
-
Michael Kozono authored
-
- 13 Mar, 2018 3 commits
-
-
Michael Kozono authored
-
Michael Kozono authored
-
Michael Kozono authored
-
- 07 Feb, 2018 1 commit
-
-
Nick Thomas authored
-
- 06 Feb, 2018 2 commits
-
-
Douwe Maan authored
-
Mayra Cabrera authored
-
- 05 Feb, 2018 1 commit
-
-
Nick Thomas authored
-
- 01 Feb, 2018 1 commit
-
-
Micaël Bergeron authored
-
- 08 Jan, 2018 1 commit
-
-
Yorick Peterse authored
This removes all usage of soft removals except for the "pending delete" system implemented for projects. This in turn simplifies all the query plans of the models that used soft removals. Since we don't really use soft removals for anything useful there's no point in keeping it around. This _does_ mean that hard removals of issues (which only admins can do if I'm not mistaken) can influence the "iid" values, but that code is broken to begin with. More on this (and how to fix it) can be found in https://gitlab.com/gitlab-org/gitlab-ce/issues/31114. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/37447
-
- 05 Jan, 2018 1 commit
-
-
Jacob Vosmaer authored
-
- 03 Jan, 2018 2 commits
-
-
Douglas Barbosa Alexandre authored
-
Douglas Barbosa Alexandre authored
-
- 08 Dec, 2017 1 commit
-
-
Mayra Cabrera authored
-
- 04 Dec, 2017 1 commit
-
-
Bob Van Landuyt authored
On the `show` of a project that is part of a fork network. We check if the user already created a fork of this project in their personal namespace. We do this in several places, so caching the result of this query in the request store prevents us from repeating it.
-
- 17 Oct, 2017 1 commit
-
-
Jen-Shin Lin authored
Security fixes for 10.1 RC See merge request gitlab/gitlabhq!2209
-
- 10 Oct, 2017 1 commit
-
-
Bob Van Landuyt authored
-
- 07 Oct, 2017 1 commit
-
-
Bob Van Landuyt authored
-
- 05 Oct, 2017 1 commit
-
-
Zeger-Jan van de Weg authored
-
- 07 Sep, 2017 1 commit
-
-
Tiago Botelho authored
-
- 06 Sep, 2017 4 commits
-
-
Michael Kozono authored
-
Michael Kozono authored
-
Michael Kozono authored
-
Michael Kozono authored
…when needed
-
- 14 Aug, 2017 1 commit
-
-
Nick Thomas authored
-
- 02 Aug, 2017 1 commit
-
-
Robert Speicher authored
-
- 27 Jul, 2017 2 commits
-
-
Rémy Coutable authored
Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
Remove superfluous lib: true, type: redis, service: true, models: true, services: true, no_db: true, api: true Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
- 18 Jul, 2017 1 commit
-
-
Bob Van Landuyt authored
-
- 17 Jul, 2017 1 commit
-
-
Nick Thomas authored
In EE, we make use of `namespace#public?` in projects. When the project is in a personal namespace, this breaks as the `public?` helper isn't present.
-
- 29 Jun, 2017 1 commit
-
-
Stan Hu authored
Group#destroy would actually hard-delete all associated projects even though the acts_as_paranoia gem is used, preventing Projects::DestroyService from doing any work. We first noticed this while trying to log all projects deletion to the Geo log.
-
- 28 Jun, 2017 1 commit
-
-
Oswaldo Ferreira authored
-
- 21 Jun, 2017 1 commit
-
-
Grzegorz Bizon authored
-
- 08 Jun, 2017 2 commits
-
-
DJ Mountney authored
Ran: - git format-patch v9.2.2..v9.2.5 --stdout > patchfile.patch - git checkout -b 9-2-5-security-patch origin/v9.2.2 - git apply patchfile.patch - git commit - [Got the sha ref for the commit] - git checkout -b upstream-9-2-security master - git cherry-pick <SHA of the patchfile commit> - [Resolved conflicts] - git cherry-pick --continue
-
DJ Mountney authored
Ran: - git format-patch v9.2.2..v9.2.5 --stdout > patchfile.patch - git checkout -b 9-2-5-security-patch origin/v9.2.2 - git apply patchfile.patch - git commit - [Got the sha ref for the commit] - git checkout -b upstream-9-2-security master - git cherry-pick <SHA of the patchfile commit> - [Resolved conflicts] - git cherry-pick --continue
-
- 24 May, 2017 3 commits
-
-
Douwe Maan authored
This reverts commit b0498c17
-
Douwe Maan authored
-
Douwe Maan authored
-
- 17 May, 2017 1 commit
-
-
Yorick Peterse authored
This commit introduces the usage of Common Table Expressions (CTEs) to efficiently retrieve nested group hierarchies, without having to rely on the "routes" table (which is an _incredibly_ inefficient way of getting the data). This requires a patch to ActiveRecord (found in the added initializer) to work properly as ActiveRecord doesn't support WITH statements properly out of the box. Unfortunately MySQL provides no efficient way of getting nested groups. For example, the old routes setup could easily take 5-10 seconds depending on the amount of "routes" in a database. Providing vastly different logic for both MySQL and PostgreSQL will negatively impact the development process. Because of this the various nested groups related methods return empty relations when used in combination with MySQL. For project authorizations the logic is split up into two classes: * Gitlab::ProjectAuthorizations::WithNestedGroups * Gitlab::ProjectAuthorizations::WithoutNestedGroups Both classes get the fresh project authorizations (= as they should be in the "project_authorizations" table), including nested groups if PostgreSQL is used. The logic of these two classes is quite different apart from their public interface. This complicates development a bit, but unfortunately there is no way around this. This commit also introduces Gitlab::GroupHierarchy. This class can be used to get the ancestors and descendants of a base relation, or both by using a UNION. This in turn is used by methods such as: * Namespace#ancestors * Namespace#descendants * User#all_expanded_groups Again this class relies on CTEs and thus only works on PostgreSQL. The Namespace methods will return an empty relation when MySQL is used, while User#all_expanded_groups will return only the groups a user is a direct member of. Performance wise the impact is quite large. For example, on GitLab.com Namespace#descendants used to take around 580 ms to retrieve data for a particular user. Using CTEs we are able to reduce this down to roughly 1 millisecond, returning the exact same data. == On The Fly Refreshing Refreshing of authorizations on the fly (= when users.authorized_projects_populated was not set) is removed with this commit. This simplifies the code, and ensures any queries used for authorizations are not mutated because they are executed in a Rails scope (e.g. Project.visible_to_user). This commit includes a migration to schedule refreshing authorizations for all users, ensuring all of them have their authorizations in place. Said migration schedules users in batches of 5000, with 5 minutes between every batch to smear the load around a bit. == Spec Changes This commit also introduces some changes to various specs. For example, some specs for ProjectTeam assumed that creating a personal project would _not_ lead to the owner having access, which is incorrect. Because we also no longer refresh authorizations on the fly for new users some code had to be added to the "empty_project" factory. This chunk of code ensures that the owner's permissions are refreshed after creating the project, something that is normally done in Projects::CreateService.
-
- 12 May, 2017 1 commit
-
-
Dmitriy Zaporozhets authored
Signed-off-by:
Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-