Commit 5dfc4fdb authored by Grégory Wisniewski's avatar Grégory Wisniewski

Remove some FIXME added or already present in the TODO list.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1096 71dcc9de-d417-0410-9af5-da40c76e7ee4
parent 3f209f29
...@@ -56,6 +56,8 @@ RC - Review output of pylint (CODE) ...@@ -56,6 +56,8 @@ RC - Review output of pylint (CODE)
Do the replication process, the verification stage, with or without Do the replication process, the verification stage, with or without
unfinished transactions, cells have to set as outdated, if yes, should the unfinished transactions, cells have to set as outdated, if yes, should the
partition table changes be broadcasted ? partition table changes be broadcasted ?
- Review PENDING/HIDDEN/SHUTDOWN states, avoid use of notifyNodeInformation
to do a state-switch, use a exception-based mechanism ?
Storage Storage
......
...@@ -891,7 +891,6 @@ class Application(object): ...@@ -891,7 +891,6 @@ class Application(object):
conn.unlock() conn.unlock()
# Wait for answers from all storages. # Wait for answers from all storages.
# FIXME this is a busy loop.
while len(self.local_var.node_tids) != len(storage_node_list): while len(self.local_var.node_tids) != len(storage_node_list):
try: try:
self._waitMessage(handler=self.storage_handler) self._waitMessage(handler=self.storage_handler)
......
...@@ -792,7 +792,6 @@ class Application(object): ...@@ -792,7 +792,6 @@ class Application(object):
state = protocol.PENDING_STATE state = protocol.PENDING_STATE
handler = storage.StorageServiceHandler handler = storage.StorageServiceHandler
elif self.cluster_state == protocol.STOPPING: elif self.cluster_state == protocol.STOPPING:
# FIXME: raise a ShuttingDownError ?
raise protocol.NotReadyError raise protocol.NotReadyError
else: else:
raise RuntimeError('unhandled cluster state') raise RuntimeError('unhandled cluster state')
......
...@@ -188,9 +188,3 @@ class DatabaseManager(object): ...@@ -188,9 +188,3 @@ class DatabaseManager(object):
the given list.""" the given list."""
raise NotImplementedError('this method must be overridden') raise NotImplementedError('this method must be overridden')
# FIXME: this was added to ensure the database connection is well closed,
# but this raised 'not implemented' exceptions from the mysql db api during
# tests. We have to check how close correctly close the database connection
# at database manager deletion.
#__del__ = close
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment